-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gen4 Planner: support aggregate UDFs #15710
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15710 +/- ##
==========================================
- Coverage 68.40% 68.40% -0.01%
==========================================
Files 1556 1556
Lines 195121 195393 +272
==========================================
+ Hits 133479 133650 +171
- Misses 61642 61743 +101 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andres Taylor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall
Signed-off-by: Andres Taylor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
The schema tracker can now tell us which aggregate UDFs exist on the underlying MySQL, and with this PR the planner will now use this information when planning queries.
It changes how the column binding is done in the
HAVING
andORDER BY
clause in a subtle but important way.Vtgate can only handle these functions when it's possible to entirely push down the aggregation to mysql.
At the moment there is no support for actually installing the UDFs on MySQL - for now this exercise is left to the user.
Related Issue(s)
#15705
Checklist
Deployment Notes