Online DDL: better support for range partitioning #15698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(applies to same table) Signed-off-by: Shlomi Noach <[email protected]>
…s always 'true' Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
…ways be true Signed-off-by: Shlomi Noach <[email protected]>
…nts, to allow multi-table DROP PARTITION statements Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
…tements combine DROP PARTITION statements Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
…o, it does not mark any particular details about a partition rotation special operation, as we do not expect such an operation to be revertible Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
shlomi-noach
added
Type: Internal Cleanup
Type: Enhancement
shlomi-noach
requested review from
mattlord,
rohit-nayak-ps,
harshit-gangal,
systay,
GuptaManan100 and
deepthi
as code owners
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
shlomi-noach
removed
NeedsDescriptionUpdate
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15698 +/- ##
==========================================
+ Coverage 68.41% 68.45% +0.04%
==========================================
Files 1558 1559 +1
Lines 196353 196302 -51
==========================================
+ Hits 134337 134388 +51
+ Misses 62016 61914 -102 ☔ View full report in Codecov by Sentry. |
dbussink
approved these changes
Apr 11, 2024
go/vt/schema/ddl_strategy.go
Outdated
| @@ -209,7 +209,7 @@ func (setting *DDLStrategySetting) IsPreferInstantDDL() bool { | |||
|
|
|||
| // IsFastRangeRotationFlag checks if strategy options include --fast-range-rotation | |||
| func (setting *DDLStrategySetting) IsFastRangeRotationFlag() bool { | |||
| return setting.hasFlag(fastRangeRotationFlag) | |||
| return true | |||
There was a problem hiding this comment.
Do we want to clean up this function in a follow up PR?
There was a problem hiding this comment.
Function is now removed.
Signed-off-by: Shlomi Noach <[email protected]>
|
Ping for review 🙏 |
mattlord
approved these changes
Apr 30, 2024
go/vt/schemadiff/analysis.go
Outdated
|
|
||
| import "vitess.io/vitess/go/vt/sqlparser" | ||
|
|
||
| // AlterTableRotatesRangePartition answers `true` when the given ALTER TABLE statemnts performas any sort |
There was a problem hiding this comment.
Obviously minor, but statemnts performas -> statement performs
| if onlineDDL.StrategySetting().IsFastRangeRotationFlag() { | ||
| op, err := analyzeDropRangePartition(alterTable, createTable) | ||
| // | ||
| // - nothing here thus far |
There was a problem hiding this comment.
Are we saying that there are no special plans which support reverts?
There was a problem hiding this comment.
At this point in time yes. If we happen to stumble on some special plan that is revertible -- that's great.
go/vt/schemadiff/analysis.go
Outdated
| // Such would be: | ||
| // - Dropping any partition(s) | ||
| // - Adding a new partition (empty, at the end of the list) | ||
| func AlterTableRotatesRangePartition(alterTable *sqlparser.AlterTable) (bool, error) { |
There was a problem hiding this comment.
As we discussed via Slack, I think that we should at least check that this is indeed a RANGE partition change (vs. e.g. LIST).
…ount and validates the table has RANGE partitioning Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context: #15674. This PR improves Online DDL support for range partitioning as follows:
--fast-range-rotationDDL strategy. The flag is still allowed, but always assumed to betrue. As discussed in Tracking: Online DDL partitioning changes improved support #15674 , a range partition rotation statement should always execute directly, and not through Online DDL.schemadifftakes ownership of range partitioning rotation analysis, instead ofonlineddl/analysis.go.ALTER TABLE ... DROP PARTITIONsupports multiple partition names.schemadiffnow generates a singleALTER TABLEwith all dropped partitions rather than splitting into multipleALTER TABLEstatements.--fast-range-rotationand assuming a range partition rotation, Online DDL devised designated plans for"add-range-partition"and for"drop-range-partition", decorated with metadata, and presented some logic for potential revertibility of some operations. After consideration, we remove this logic. We cannot achieve revertibility for the entire set of partition rotation scenarios, and we choose to not offer revertibility for any of them, just as we don't offer revertibility forinstant-ddl.Related Issue(s)
#15674
Checklist
Deployment Notes