Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Kill Query for Non-Transaction Query Execution and Update Query Timeout / Cancelled Error Message #15694

Merged
merged 9 commits into from
Apr 23, 2024

addressed review comments

bd27474
Select commit
Loading
Failed to load commit list.
Merged

Use Kill Query for Non-Transaction Query Execution and Update Query Timeout / Cancelled Error Message #15694

addressed review comments
bd27474
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 23, 2024 in 0s

68.42% (+0.01%) compared to f118ba2

View this Pull Request on Codecov

68.42% (+0.01%) compared to f118ba2

Details

Codecov Report

Attention: Patch coverage is 89.53488% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 68.42%. Comparing base (f118ba2) to head (bd27474).
Report is 22 commits behind head on main.

Files Patch % Lines
go/vt/vttablet/tabletserver/connpool/dbconn.go 94.80% 4 Missing ⚠️
go/vt/vttablet/onlineddl/executor.go 0.00% 3 Missing ⚠️
go/vt/vttablet/tabletserver/query_list.go 66.66% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15694      +/-   ##
==========================================
+ Coverage   68.40%   68.42%   +0.01%     
==========================================
  Files        1556     1556              
  Lines      195121   195490     +369     
==========================================
+ Hits       133479   133764     +285     
- Misses      61642    61726      +84

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov