Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent adding to query details after unserve common has started #15684

Merged

feat: fix race where we set cluster action to not accepting queries a…

880c5e3
Select commit
Loading
Failed to load commit list.
Merged

Prevent adding to query details after unserve common has started #15684

feat: fix race where we set cluster action to not accepting queries a…
880c5e3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 11, 2024 in 0s

68.40% (+0.26%) compared to 4a1870a

View this Pull Request on Codecov

68.40% (+0.26%) compared to 4a1870a

Details

Codecov Report

Attention: Patch coverage is 86.66667% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 68.40%. Comparing base (4a1870a) to head (880c5e3).
Report is 18 commits behind head on main.

Files Patch % Lines
go/vt/vttablet/tabletserver/query_executor.go 66.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15684      +/-   ##
==========================================
+ Coverage   68.13%   68.40%   +0.26%     
==========================================
  Files        1556     1556              
  Lines      195028   195136     +108     
==========================================
+ Hits       132888   133476     +588     
+ Misses      62140    61660     -480     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.