-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't forget DISTINCT for derived tables #15672
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systay
added
Type: Bug
Component: Query Serving
Backport to: release-17.0
Backport to: release-19.0
Needs to be back ported to release-19.0
labels
Apr 8, 2024
systay
requested review from
harshit-gangal,
frouioui,
GuptaManan100 and
arthurschreiber
as code owners
April 8, 2024 05:50
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Apr 8, 2024
systay
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Apr 8, 2024
Signed-off-by: Andres Taylor <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15672 +/- ##
=======================================
Coverage 68.13% 68.13%
=======================================
Files 1556 1556
Lines 195028 195029 +1
=======================================
+ Hits 132888 132890 +2
+ Misses 62140 62139 -1 ☔ View full report in Codecov by Sentry. |
GuptaManan100
approved these changes
Apr 8, 2024
harshit-gangal
approved these changes
Apr 8, 2024
vitess-bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
Signed-off-by: Andres Taylor <[email protected]>
vitess-bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
Signed-off-by: Andres Taylor <[email protected]>
vitess-bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
Signed-off-by: Andres Taylor <[email protected]>
systay
pushed a commit
that referenced
this pull request
Apr 8, 2024
systay
added a commit
that referenced
this pull request
Apr 9, 2024
…#15677) Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Andres Taylor <[email protected]>
systay
added a commit
that referenced
this pull request
Apr 9, 2024
…#15676) Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Andres Taylor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport to: release-19.0
Needs to be back ported to release-19.0
Component: Query Serving
Type: Bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the planner is able to push down a derived table and everything that goes with it under a route, we were not copying over whether the SELECT was distinct or not.
Related Issue(s)
Fixes #13578
Checklist