Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't forget DISTINCT for derived tables #15672

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

systay
Copy link
Collaborator

@systay systay commented Apr 8, 2024

Description

When the planner is able to push down a derived table and everything that goes with it under a route, we were not copying over whether the SELECT was distinct or not.

Related Issue(s)

Fixes #13578

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Copy link
Contributor

vitess-bot bot commented Apr 8, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Apr 8, 2024
@systay systay removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Apr 8, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Apr 8, 2024
@systay systay force-pushed the distinct-derived branch from 84ebb8d to 743b161 Compare April 8, 2024 06:44
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.13%. Comparing base (4a1870a) to head (743b161).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15672   +/-   ##
=======================================
  Coverage   68.13%   68.13%           
=======================================
  Files        1556     1556           
  Lines      195028   195029    +1     
=======================================
+ Hits       132888   132890    +2     
+ Misses      62140    62139    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harshit-gangal harshit-gangal merged commit e118bbc into vitessio:main Apr 8, 2024
103 checks passed
@harshit-gangal harshit-gangal deleted the distinct-derived branch April 8, 2024 13:01
vitess-bot pushed a commit that referenced this pull request Apr 8, 2024
vitess-bot pushed a commit that referenced this pull request Apr 8, 2024
vitess-bot pushed a commit that referenced this pull request Apr 8, 2024
systay pushed a commit that referenced this pull request Apr 8, 2024
…#15678)

Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
systay added a commit that referenced this pull request Apr 9, 2024
…#15677)

Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Andres Taylor <[email protected]>
systay added a commit that referenced this pull request Apr 9, 2024
…#15676)

Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Andres Taylor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: planner drops DISTINCT from derived table to sharded keyspace with unique lookup column
3 participants