Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Upgrade/Downgrade use N+1 version of vtctld when testing with N+1 of vttablet #15631

Conversation

rohit-nayak-ps
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps commented Apr 3, 2024

Description

Makes a similar change done in the multi-tenant PR at https://github.com/vitessio/vitess/pull/15503/files#diff-79c61525895b1e17d0cc49054a0d19f9264073042bbe75a8f5997092f02a3c92R203-R210

We need to use the same version of vtctld as vttablets.

Otherwise this workflow fails since it cannot insert into _vt.vreplication which now has a json column for which we cannot specify a default at the table schema level.

This is being done directly on v19 since the versions of vttablet/vtctlds of upgrade/downgrade are reversed as compared to main (v20) and v19.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented Apr 3, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Apr 3, 2024
@github-actions github-actions bot added this to the v19.0.2 milestone Apr 3, 2024
@rohit-nayak-ps rohit-nayak-ps added Type: Bug Component: Build/CI and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Apr 3, 2024
@deepthi
Copy link
Member

deepthi commented Apr 3, 2024

In general we want all combinations of versions to work. So why is this PR acceptable?

  • The specific tests are meant to test vttablet/vtgate cross-version compatibility. vtctld is somewhat incidental to the testing
  • the reference test creates a Materialize workflow while the cluster is in mixed-version mode. This is not something that we support in production. You create your workflow on a stable cluster, and it will continue working through upgrades/downgrades.
  • the current upgrade/downgrade testing framework does not make it easy to start a test, and then do an upgrade/downgrade. It first does the upgrade/downgrade and then runs a bunch of existing e2e tests.

@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review April 3, 2024 21:22
@deepthi deepthi merged commit 255abef into vitessio:release-19.0 Apr 3, 2024
107 of 112 checks passed
@deepthi deepthi deleted the rohit/upgrade-downgrade-queries-fix-19 branch April 3, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants