Remove vitess/base and vitess/k8s Docker images

[frouioui]

Description

This PR removes the vitess/base and vitess/k8s images. From now on and in most cases the "root" image is vitess/bootstrap for everything. Binary-specific images will be built from the vitess/lite image.

Related Issue(s)

• Fixes Remove vitess/base and build binary-specific images from vitess/lite #15606

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[frouioui]

I removed docker/release and the corresponding make command as it seems to not be used and very ancient.

[deepthi]

Agreed. It was being used by the pre-GH release process.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.12%. Comparing base (37cc00a) to head (9bc5f23).
Report is 12 commits behind head on main.

❗ Current head 9bc5f23 differs from pull request most recent head a7d69df. Consider uploading reports for the commit a7d69df to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #15620      +/-   ##
==========================================
+ Coverage   68.03%   68.12%   +0.08%     
==========================================
  Files        1561     1556       -5     
  Lines      195526   194984     -542     
==========================================
- Hits       133023   132827     -196     
+ Misses      62503    62157     -346     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[frouioui]

The image vitess/k8s now relies on vitess/lite, which runs make install. In vitess/k8s we copy these binaries so they are available for the binary-specific images. I had to add the missing binaries that we use in vitess/k8s.

[frouioui]

Those two binaries are already present in vitess/lite no need to copy them and no need for a base or bootstrap image.

[deepthi]

I'm good with this. I believe historically the k8s images were never migrated to use lite instead of base and this just fixes that. I can't think of a reason why someone would want to use base any more.
Let's get @derekperkins's take on this before we merge.

[deepthi]

Going through the checklist - does this affect vitess-operator in any way?

[derekperkins]

LGTM. We could go even further I think and eliminate the k8s container, and build all of the subsequent containers from lite directly. It originally existed mostly because lite didn't have everything, and base was too large to work with. Probably best to do that in a separate PR

[deepthi]

If no one is using these images we may be able to skip the release notes too.

[frouioui]

Going through the checklist - does this affect vitess-operator in any way?

I don't think it does, even for our tests. But if it does we will know soon enough.

[frouioui]

We could go even further I think and eliminate the k8s container, and build all of the subsequent containers from lite directly

Achieved via 0fa9fdb.

[frouioui]

If no one is using these images we may be able to skip the release notes too.

It does not hurt to add a mention in the release notes 😃 Done via a7d69df