Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetTablets from Vtctldclient #15596

Closed
wants to merge 5 commits into from
Closed

GetTablets from Vtctldclient #15596

wants to merge 5 commits into from

Conversation

notfelineit
Copy link
Contributor

@notfelineit notfelineit commented Mar 29, 2024 •
edited
Loading

Description

A newer version of #14342

Addresses #14152 by fetching tablets from Vtctld instead of a single VTGate instance. State (serving state) will be supplemented by results from Vtctld.RunHealthCheck.

Related Issue(s)

#14152

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 29, 2024 •
edited by notfelineit
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Mar 29, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Mar 29, 2024
notfelineit
notfelineit commented Mar 29, 2024
View reviewed changes
go/vt/vtadmin/cluster/cluster.go
_, err := c.Vtctld.RunHealthCheck(ctx, &vtctldatapb.RunHealthCheckRequest{
TabletAlias: tablet.Alias,
})
if err != nil {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping the original comment from @ajm188 here:

just dropping a placeholder so i don't forget about the UNKNOWN vs NOT_SERVING distinction here

@notfelineit
TestFindSchema all pass
18ef876 
Signed-off-by: notfelineit <[email protected]>
notfelineit
notfelineit commented Mar 29, 2024
View reviewed changes
go/vt/vtadmin/testutil/authztestgen/config.json
{
"field": "RunHealthCheckResults",
"type": "map[string]error",
"value": "\"other1-0000000100\": nil,"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was key to getting TestGetSchemas to pass because we now use RunHealthCheck to determine the serving state of a tablet.

@notfelineit notfelineit added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: VTAdmin VTadmin interface go and removed NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Mar 29, 2024
@notfelineit
Copy link
Contributor Author

Pausing here for today. There are a few more tests to update:

  • TestFindSchema
  • TestVTExplain
  • TestFindTablets

@notfelineit
Copy link
Contributor Author

This is blocked on #15603 a more reliable healthcheck to indicate tablet is serving/not-serving/unknown

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2024

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label May 2, 2024
@notfelineit notfelineit removed the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label May 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 2, 2024

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label Jun 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 9, 2024

This PR was closed because it has been stale for 7 days with no activity.

@github-actions github-actions bot closed this Jun 9, 2024
@notfelineit
Copy link
Contributor Author

I'll have to reopen this once the new healthcheck is implemented 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajm188 ajm188 Awaiting requested review from ajm188 ajm188 will be requested when the pull request is marked ready for review ajm188 is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps will be requested when the pull request is marked ready for review rohit-nayak-ps is a code owner

Assignees
No one assigned
Labels
Component: VTAdmin VTadmin interface go NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
v20.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@notfelineit