VTOrc: Rework recovery registration

[GuptaManan100]

Description

This PR reworks the recovery registration. We do not need an active period for recoveries since VTOrc refreshes all the required information after acquiring a shard lock, and then checking again if the analysis is still valid. This rework also fixes the issue described in #15512 since we will no longer be waiting for recoveries that are in active period. The only recoveries we wait for now are the ones that are currently in progress.

While making this change, a lot of unused fields from tables, and a couple of unused tables have also been removed.

Related Issue(s)

• Fixes Bug Report: DemotePrimary fix delayed because of a PrimarySemiSyncMustBeSet recovery attempt right before #15512

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

Attention: Patch coverage is 80.30303% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 68.06%. Comparing base (696fe0e) to head (72a6137).
Report is 171 commits behind head on main.

Files	Patch %	Lines
go/vt/vtorc/logic/topology_recovery.go	41.66%	7 Missing ⚠️
go/vt/vtorc/logic/topology_recovery_dao.go	93.47%	3 Missing ⚠️
go/cmd/vtorc/cli/cli.go	0.00%	1 Missing ⚠️
go/vt/vtorc/config/config.go	0.00%	1 Missing ⚠️
go/vt/vtorc/logic/vtorc.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #15591      +/-   ##
==========================================
+ Coverage   67.41%   68.06%   +0.64%     
==========================================
  Files        1560     1562       +2     
  Lines      192752   195368    +2616     
==========================================
+ Hits       129952   132975    +3023     
+ Misses      62800    62393     -407     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dbussink]

The cleanup is also really nice here as well.

[deepthi]

lol