Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evalengine: Implement TO_SECONDS #15590

Merged
merged 2 commits into from
Apr 1, 2024

Fix mysqlDocSamples TO_SECONDS tests

1c59cbe
Select commit
Loading
Failed to load commit list.
Merged

evalengine: Implement TO_SECONDS #15590

Fix mysqlDocSamples TO_SECONDS tests
1c59cbe
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 28, 2024 in 1s

65.79% (+0.00%) compared to 2078d62

View this Pull Request on Codecov

65.79% (+0.00%) compared to 2078d62

Details

Codecov Report

Attention: Patch coverage is 96.61017% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 65.79%. Comparing base (2078d62) to head (1c59cbe).

Files Patch % Lines
go/vt/vtgate/evalengine/fn_time.go 95.45% 1 Missing ⚠️
go/vt/vtgate/evalengine/translate_builtin.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15590   +/-   ##
=======================================
  Coverage   65.78%   65.79%           
=======================================
  Files        1561     1561           
  Lines      194838   194897   +59     
=======================================
+ Hits       128183   128223   +40     
- Misses      66655    66674   +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.