-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add missing tests for go/vt/mysqlctl
#15585
Conversation
Signed-off-by: Noble Mittal <[email protected]>
Signed-off-by: Noble Mittal <[email protected]>
Signed-off-by: Noble Mittal <[email protected]>
Signed-off-by: Noble Mittal <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Noble Mittal <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15585 +/- ##
==========================================
+ Coverage 68.13% 68.40% +0.26%
==========================================
Files 1556 1556
Lines 195028 195028
==========================================
+ Hits 132888 133400 +512
+ Misses 62140 61628 -512 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Noble Mittal <[email protected]>
go/vt/mysqlctl
go/vt/mysqlctl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest looks good.
Signed-off-by: Noble Mittal <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Manan Gupta <[email protected]>
Description
This PR adds missing tests for
go/vt/mysqlctl
Related Issue(s)
Checklist
Deployment Notes