-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: make sure we use the right Offset #15576
Conversation
Signed-off-by: Andres Taylor <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15576 +/- ##
==========================================
- Coverage 67.41% 65.75% -1.67%
==========================================
Files 1560 1561 +1
Lines 192752 194830 +2078
==========================================
- Hits 129952 128107 -1845
- Misses 62800 66723 +3923 ☔ View full report in Codecov by Sentry. |
Do we need to back port this to stay consistent? |
I don't think that is important |
Description
Minor clean-up: we were looking for
*Offset
, but the type used isOffset
.The end-result was the same, but we were taking an unnecessarily long way to get there.