-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add testing for shard scoped foreign keys #15571
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Mar 26, 2024
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
added
Component: Query Serving
Type: Testing
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Mar 27, 2024
GuptaManan100
requested review from
harshit-gangal,
systay and
frouioui
as code owners
March 27, 2024 06:23
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15571 +/- ##
=======================================
Coverage ? 65.78%
=======================================
Files ? 1561
Lines ? 194838
Branches ? 0
=======================================
Hits ? 128181
Misses ? 66657
Partials ? 0 ☔ View full report in Codecov by Sentry. |
harshit-gangal
approved these changes
Mar 27, 2024
Signed-off-by: Manan Gupta <[email protected]>
deepthi
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds testing for shard-scoped foreign keys. While making these changes we realised that for shard-scoped foreign keys, the foreign key columns have to be part of the sharding key, which automatically fails all the updates on those columns! 😿
So, we can currently only support
DELETE RESTRICT
andDELETE CASCADE
style operations. This PR adds the infra for adding the tests for all the scenarios but skips all the ones that don't work for now. For the same reason, I haven't enabled fuzzer tests either for shard-scoped foreign keys because of the very limited number of queries that actually work.Here are the tests that work as intended -
Related Issue(s)
Checklist
Deployment Notes