-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proto
: lexical ordering of ExecuteMultiFetchAsDBA
#15558
Merged
shlomi-noach
merged 2 commits into
vitessio:main
from
planetscale:execute-multi-fetch-as-dba-lexical
Mar 24, 2024
Merged
proto
: lexical ordering of ExecuteMultiFetchAsDBA
#15558
shlomi-noach
merged 2 commits into
vitessio:main
from
planetscale:execute-multi-fetch-as-dba-lexical
Mar 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cographically Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
shlomi-noach
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: TabletManager
Component: vtctldclient
labels
Mar 24, 2024
shlomi-noach
requested review from
deepthi,
harshit-gangal,
mattlord,
ajm188,
notfelineit and
rohit-nayak-ps
as code owners
March 24, 2024 06:53
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Mar 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15558 +/- ##
==========================================
- Coverage 67.41% 65.74% -1.67%
==========================================
Files 1560 1560
Lines 192752 194595 +1843
==========================================
- Hits 129952 127945 -2007
- Misses 62800 66650 +3850 ☔ View full report in Codecov by Sentry. |
shlomi-noach
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Mar 24, 2024
dbussink
approved these changes
Mar 24, 2024
rohit-nayak-ps
approved these changes
Mar 24, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: TabletManager
Component: vtctldclient
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quick followup to #15506
This PR introduces no change to functionality. However, it solves a problem with #15506: the new
ExecuteMultiFetchAsDBA
method, andExecuteMultiFetchAsDBARequest
andExecuteMultiFetchAsDBAResponse
messages, were defined inproto
file right afterExecuteFetchAsDBA
, but that's incorrect lexically and should have been defined afterExecuteHook
.Lexical ordering matters because autogenerated code works lexically, which causes unwanted
diffs
.Related Issue(s)
#15505
Checklist
Deployment Notes