Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oops #15542

Closed
wants to merge 236 commits into from

Backport https://github.com/vitessio/vitess/pull/15275

bab4912
Select commit
Loading
Failed to load commit list.
Closed

oops #15542

Backport https://github.com/vitessio/vitess/pull/15275
bab4912
Select commit
Loading
Failed to load commit list.
DCO / DCO required action Mar 21, 2024 in 2s

DCO

There are 91 commits incorrectly signed off. This means that the author(s) of these commits failed to include a Signed-off-by line in their commit message.

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <[email protected]> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Here is how to fix the problem so that this code can be merged.


Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using --allow-empty)

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~236 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin hm/backport-vtexplain-fix

Summary

Commit sha: bafc21d, Author: Andrés Taylor, Committer: GitHub; Can not find "Andrés Taylor [email protected]", in ["Andres Taylor [email protected]", "Manan Gupta [email protected]"].
Commit sha: a8b6d48, Author: Andrés Taylor, Committer: GitHub; The sign-off is missing.
Commit sha: 4a0e038, Author: David Piegza, Committer: Arthur Schreiber; The sign-off is missing.
Commit sha: c37bdd7, Author: Deepthi Sigireddi, Committer: GitHub; Can not find "Deepthi Sigireddi [email protected]", in ["deepthi [email protected]", "Florent Poinsard [email protected]", "Manan Gupta [email protected]", "Manan Gupta [email protected]", "Manan Gupta [email protected]", "deepthi [email protected]", "Florent Poinsard [email protected]", "Manan Gupta [email protected]"].
Commit sha: 25f615d, Author: Deepthi Sigireddi, Committer: GitHub; Can not find "Deepthi Sigireddi [email protected]", in ["Andy Lim [email protected]", "deepthi [email protected]"].
Commit sha: 2aa039c, Author: Deepthi Sigireddi, Committer: GitHub; Expected "Deepthi Sigireddi [email protected]", but got "deepthi [email protected]".
Commit sha: e8c258d, Author: Florent Poinsard, Committer: GitHub; Expected "Florent Poinsard [email protected]", but got "Florent Poinsard [email protected]".
Commit sha: 8c57874, Author: Florent Poinsard, Committer: GitHub; Expected "Florent Poinsard [email protected]", but got "Florent Poinsard [email protected]".
Commit sha: 659c9c0, Author: Florent Poinsard, Committer: GitHub; Can not find "Florent Poinsard [email protected]", in ["Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]"].
Commit sha: 08362bc, Author: Florent Poinsard, Committer: GitHub; Can not find "Florent Poinsard [email protected]", in ["Shlomi Noach [email protected]", "Rohit Nayak [email protected]"].
Commit sha: 52defd6, Author: Florent Poinsard, Committer: GitHub; Can not find "Florent Poinsard [email protected]", in ["Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]"].
Commit sha: 79014d3, Author: Florent Poinsard, Committer: GitHub; Can not find "Florent Poinsard [email protected]", in ["Florent Poinsard [email protected]", "Harshit Gangal [email protected]", "Florent Poinsard [email protected]", "Harshit Gangal [email protected]"].
Commit sha: aa377fb, Author: Florent Poinsard, Committer: GitHub; Can not find "Florent Poinsard [email protected]", in ["Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Dirkjan Bussink [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Dirkjan Bussink [email protected]"].
Commit sha: 7cb8f43, Author: Florent Poinsard, Committer: GitHub; Expected "Florent Poinsard [email protected]", but got "Florent Poinsard [email protected]".
Commit sha: a62c600, Author: Florent Poinsard, Committer: GitHub; Expected "Florent Poinsard [email protected]", but got "Florent Poinsard [email protected]".
Commit sha: 8635865, Author: Florent Poinsard, Committer: GitHub; Expected "Florent Poinsard [email protected]", but got "Florent Poinsard [email protected]".
Commit sha: fbfc366, Author: Florent Poinsard, Committer: GitHub; Can not find "Florent Poinsard [email protected]", in ["Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]"].
Commit sha: fcd0d60, Author: Florent Poinsard, Committer: GitHub; Can not find "Florent Poinsard [email protected]", in ["Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]"].
Commit sha: 0f0ed28, Author: Florent Poinsard, Committer: GitHub; Expected "Florent Poinsard [email protected]", but got "Florent Poinsard [email protected]".
Commit sha: 480a99d, Author: Florent Poinsard, Committer: GitHub; Can not find "Florent Poinsard [email protected]", in ["Florent Poinsard [email protected]", "Andres Taylor [email protected]"].
Commit sha: dc0bd69, Author: Florent Poinsard, Committer: GitHub; Can not find "Florent Poinsard [email protected]", in ["Florent Poinsard [email protected]", "Andres Taylor [email protected]"].
Commit sha: 75b02ea, Author: Florent Poinsard, Committer: GitHub; Expected "Florent Poinsard [email protected]", but got "Andres Taylor [email protected]".
Commit sha: bb6e0da, Author: Florent Poinsard, Committer: GitHub; Can not find "Florent Poinsard [email protected]", in ["Andres Taylor [email protected]", "Andres Taylor [email protected]", "Florent Poinsard [email protected]"].
Commit sha: 859dfb4, Author: Florent Poinsard, Committer: GitHub; Can not find "Florent Poinsard [email protected]", in ["Hormoz Kheradmand [email protected]", "Florent Poinsard [email protected]"].
Commit sha: 970b8ff, Author: Florent Poinsard, Committer: GitHub; Expected "Florent Poinsard [email protected]", but got "Florent Poinsard [email protected]".
Commit sha: 984793f, Author: Florent Poinsard, Committer: GitHub; Expected "Florent Poinsard [email protected]", but got "Florent Poinsard [email protected]".
Commit sha: 5ee1e46, Author: Florent Poinsard, Committer: GitHub; Expected "Florent Poinsard [email protected]", but got "Florent Poinsard [email protected]".
Commit sha: af8e5e5, Author: Florent Poinsard, Committer: GitHub; Expected "Florent Poinsard [email protected]", but got "Shlomi Noach [email protected]".
Commit sha: b04435f, Author: Florent Poinsard, Committer: GitHub; Expected "Florent Poinsard [email protected]", but got "Andrew Mason [email protected]".
Commit sha: d6c92cb, Author: Florent Poinsard, Committer: GitHub; Expected "Florent Poinsard [email protected]", but got "Dirkjan Bussink [email protected]".
Commit sha: 2193482, Author: Florent Poinsard, Committer: GitHub; The sign-off is missing.
Commit sha: ee547c8, Author: Florent Poinsard, Committer: GitHub; Can not find "Florent Poinsard [email protected]", in ["Andres Taylor [email protected]", "Florent Poinsard [email protected]"].
Commit sha: dbb2cf7, Author: Florent Poinsard, Committer: GitHub; Expected "Florent Poinsard [email protected]", but got "Florent Poinsard [email protected]".
Commit sha: e18974d, Author: Florent Poinsard, Committer: GitHub; Can not find "Florent Poinsard [email protected]", in ["Harshit Gangal [email protected]", "harshit-gangal [email protected]", "harshit-gangal [email protected]", "Harshit Gangal [email protected]", "harshit-gangal [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Harshit Gangal [email protected]", "harshit-gangal [email protected]", "Florent Poinsard [email protected]"].
Commit sha: 818ccd5, Author: Florent Poinsard, Committer: GitHub; Expected "Florent Poinsard [email protected]", but got "Florent Poinsard [email protected]".
Commit sha: 625c057, Author: Florent Poinsard, Committer: GitHub; Can not find "Florent Poinsard [email protected]", in ["Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]"].
Commit sha: 7a9a84a, Author: Florent Poinsard, Committer: GitHub; The sign-off is missing.
Commit sha: ee4fe7c, Author: Florent Poinsard, Committer: GitHub; Can not find "Florent Poinsard [email protected]", in ["Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]"].
Commit sha: 47a1042, Author: Florent Poinsard, Committer: GitHub; Expected "Florent Poinsard [email protected]", but got "Florent Poinsard [email protected]".
Commit sha: 00c7591, Author: Florent Poinsard, Committer: GitHub; Expected "Florent Poinsard [email protected]", but got "Florent Poinsard [email protected]".
Commit sha: 1f393a4, Author: Florent Poinsard, Committer: GitHub; Expected "Florent Poinsard [email protected]", but got "Florent Poinsard [email protected]".
Commit sha: 8fa5816, Author: Harshit Gangal, Committer: GitHub; The sign-off is missing.
Commit sha: bab4912, Author: Henri Maurer, Committer: Henri Maurer; The sign-off is missing.
Commit sha: 27e04c1, Author: Manan Gupta, Committer: GitHub; Expected "Manan Gupta [email protected]", but got "Manan Gupta [email protected]".
Commit sha: 5334b22, Author: Manan Gupta, Committer: GitHub; Can not find "Manan Gupta [email protected]", in ["Manan Gupta [email protected]", "Manan Gupta [email protected]", "Manan Gupta [email protected]"].
Commit sha: 4e32ce1, Author: Manan Gupta, Committer: GitHub; Expected "Manan Gupta [email protected]", but got "Manan Gupta [email protected]".
Commit sha: 51a7abf, Author: Manan Gupta, Committer: GitHub; Expected "Manan Gupta [email protected]", but got "Manan Gupta [email protected]".
Commit sha: ae796b2, Author: Manan Gupta, Committer: GitHub; Expected "Manan Gupta [email protected]", but got "Manan Gupta [email protected]".
Commit sha: 492cf00, Author: Manan Gupta, Committer: GitHub; Can not find "Manan Gupta [email protected]", in ["Manan Gupta [email protected]", "deepthi [email protected]", "Manan Gupta [email protected]", "Manan Gupta [email protected]", "deepthi [email protected]"].
Commit sha: 8b9baff, Author: Manan Gupta, Committer: GitHub; Expected "Manan Gupta [email protected]", but got "Manan Gupta [email protected]".
Commit sha: 0598be6, Author: Manan Gupta, Committer: GitHub; Can not find "Manan Gupta [email protected]", in ["Manan Gupta [email protected]", "Manan Gupta [email protected]", "Manan Gupta [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Florent Poinsard [email protected]", "Manan Gupta [email protected]", "Florent Poinsard [email protected]"].
Commit sha: ae10400, Author: Manan Gupta, Committer: GitHub; Expected "Manan Gupta [email protected]", but got "Manan Gupta [email protected]".
Commit sha: e55ceed, Author: Manan Gupta, Committer: GitHub; Can not find "Manan Gupta [email protected]", in ["Manan Gupta [email protected]", "Manan Gupta [email protected]", "Manan Gupta [email protected]", "Manan Gupta [email protected]"].
Commit sha: bb768df, Author: Manan Gupta, Committer: GitHub; Can not find "Manan Gupta [email protected]", in ["Manan Gupta [email protected]", "Manan Gupta [email protected]", "Matt Lord [email protected]", "Matt Lord [email protected]", "Manan Gupta [email protected]", "Manan Gupta [email protected]", "Manan Gupta [email protected]", "Manan Gupta [email protected]", "Manan Gupta [email protected]", "Matt Lord [email protected]"].
Commit sha: dfd698d, Author: Manan Gupta, Committer: GitHub; Expected "Manan Gupta [email protected]", but got "Manan Gupta [email protected]".
Commit sha: 49ac1d6, Author: Manan Gupta, Committer: GitHub; Expected "Manan Gupta [email protected]", but got "Manan Gupta [email protected]".
Commit sha: db53f78, Author: Manan Gupta, Committer: GitHub; Expected "Manan Gupta [email protected]", but got "Manan Gupta [email protected]".
Commit sha: 7f9e1e1, Author: Manan Gupta, Committer: GitHub; Expected "Manan Gupta [email protected]", but got "Manan Gupta [email protected]".
Commit sha: 306c7d7, Author: Manan Gupta, Committer: GitHub; Expected "Manan Gupta [email protected]", but got "Matt Lord [email protected]".
Commit sha: 098913a, Author: Manan Gupta, Committer: GitHub; Expected "Manan Gupta [email protected]", but got "Manan Gupta [email protected]".
Commit sha: d1ba625, Author: Manan Gupta, Committer: GitHub; Can not find "Manan Gupta [email protected]", in ["Manan Gupta [email protected]", "Manan Gupta [email protected]", "Manan Gupta [email protected]", "Florent Poinsard [email protected]", "Manan Gupta [email protected]", "Florent Poinsard [email protected]"].
Commit sha: 2d2d1df, Author: Manan Gupta, Committer: GitHub; Expected "Manan Gupta [email protected]", but got "Manan Gupta [email protected]".
Commit sha: 6934444, Author: Manan Gupta, Committer: GitHub; Can not find "Manan Gupta [email protected]", in ["Manan Gupta [email protected]", "Manan Gupta [email protected]", "Manan Gupta [email protected]"].
Commit sha: 6076fed, Author: Manan Gupta, Committer: GitHub; Can not find "Manan Gupta [email protected]", in ["Manan Gupta [email protected]", "Manan Gupta [email protected]", "Florent Poinsard [email protected]", "Manan Gupta [email protected]", "Florent Poinsard [email protected]"].
Commit sha: 1597b68, Author: Manan Gupta, Committer: GitHub; Expected "Manan Gupta [email protected]", but got "Manan Gupta [email protected]".
Commit sha: 272004c, Author: Manan Gupta, Committer: GitHub; Can not find "Manan Gupta [email protected]", in ["Manan Gupta [email protected]", "Manan Gupta [email protected]", "Manan Gupta [email protected]", "Manan Gupta [email protected]", "Manan Gupta [email protected]"].
Commit sha: 1714d17, Author: Manan Gupta, Committer: GitHub; The sign-off is missing.
Commit sha: 2d41d38, Author: Manan Gupta, Committer: GitHub; Expected "Manan Gupta [email protected]", but got "Manan Gupta [email protected]".
Commit sha: 7251cb3, Author: Manan Gupta, Committer: GitHub; The sign-off is missing.
Commit sha: 99d39f9, Author: Manan Gupta, Committer: GitHub; The sign-off is missing.
Commit sha: af3cd0a, Author: Manan Gupta, Committer: GitHub; The sign-off is missing.
Commit sha: 19db42e, Author: Manan Gupta, Committer: GitHub; The sign-off is missing.
Commit sha: 721d2c3, Author: Manan Gupta, Committer: GitHub; Expected "Manan Gupta [email protected]", but got "Manan Gupta [email protected]".
Commit sha: c15ecd0, Author: Manan Gupta, Committer: GitHub; Expected "Manan Gupta [email protected]", but got "Manan Gupta [email protected]".
Commit sha: 66e1b17, Author: Manan Gupta, Committer: GitHub; Expected "Manan Gupta [email protected]", but got "Manan Gupta [email protected]".
Commit sha: a93cb55, Author: Manan Gupta, Committer: GitHub; Expected "Manan Gupta [email protected]", but got "Manan Gupta [email protected]".
Commit sha: 0904ef0, Author: Manan Gupta, Committer: GitHub; The sign-off is missing.
Commit sha: c4efce0, Author: Manan Gupta, Committer: GitHub; Expected "Manan Gupta [email protected]", but got "Manan Gupta [email protected]".
Commit sha: 87ea735, Author: Manan Gupta, Committer: GitHub; Expected "Manan Gupta [email protected]", but got "Manan Gupta [email protected]".
Commit sha: 6cf15c8, Author: Manan Gupta, Committer: GitHub; Expected "Manan Gupta [email protected]", but got "Manan Gupta [email protected]".
Commit sha: 12cdda1, Author: Manan Gupta, Committer: GitHub; Expected "Manan Gupta [email protected]", but got "Manan Gupta [email protected]".
Commit sha: fd462ff, Author: Manan Gupta, Committer: GitHub; The sign-off is missing.
Commit sha: e429768, Author: Rohit Nayak, Committer: GitHub; Can not find "Rohit Nayak [email protected]", in ["Shlomi Noach [email protected]", "Rohit Nayak [email protected]", "Shlomi Noach [email protected]", "Rohit Nayak [email protected]", "Rohit Nayak [email protected]", "Shlomi Noach [email protected]", "Rohit Nayak [email protected]"].
Commit sha: 2b43fd7, Author: Rohit Nayak, Committer: GitHub; Can not find "Rohit Nayak [email protected]", in ["Rohit Nayak [email protected]", "Rohit Nayak [email protected]", "Rohit Nayak [email protected]"].
Commit sha: 7b2de23, Author: Rohit Nayak, Committer: GitHub; Can not find "Rohit Nayak [email protected]", in ["Matt Lord [email protected]", "Matt Lord [email protected]", "Matt Lord [email protected]", "Matt Lord [email protected]", "Matt Lord [email protected]", "Matt Lord [email protected]", "Max Englander [email protected]", "Matt Lord [email protected]", "Max Englander [email protected]"].
Commit sha: 630728f, Author: Rohit Nayak, Committer: GitHub; Expected "Rohit Nayak [email protected]", but got "Rohit Nayak [email protected]".
Commit sha: d4e5cc7, Author: Rohit Nayak, Committer: GitHub; Expected "Rohit Nayak [email protected]", but got "Rohit Nayak [email protected]".
Commit sha: a682c1e, Author: Rohit Nayak, Committer: GitHub; Expected "Rohit Nayak [email protected]", but got "Rohit Nayak [email protected]".
Commit sha: 73e8ae1, Author: Rohit Nayak, Committer: GitHub; Expected "Rohit Nayak [email protected]", but got "Rohit Nayak [email protected]".
Commit sha: 4a810e4, Author: Shlomi Noach, Committer: GitHub; The sign-off is missing.
Commit sha: 266b2d8, Author: Shlomi Noach, Committer: GitHub; The sign-off is missing.