-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce excessing logging in CI #15462
Reduce excessing logging in CI #15462
Conversation
Signed-off-by: Rohit Nayak <[email protected]>
…ogs during installations Signed-off-by: Rohit Nayak <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
…hecks Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
… original file back with just apt-get and curl muted Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15462 +/- ##
==========================================
+ Coverage 65.63% 65.73% +0.09%
==========================================
Files 1563 1560 -3
Lines 194395 194595 +200
==========================================
+ Hits 127594 127916 +322
+ Misses 66801 66679 -122 ☔ View full report in Codecov by Sentry. |
… this PR Signed-off-by: Rohit Nayak <[email protected]>
@@ -164,4 +164,4 @@ jobs: | |||
fi | |||
|
|||
# print test output | |||
cat output.txt | |||
cat output.txt | grep -ivE '(PASS|RUN).*(Collation|Test.*Valid|TestRemoteWildcardMatches|Fuzz|tpcc|TestParse|PITR|cases|TestPlan|Super.*long)|DBClient' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about this part, but the rest looks good. Do you see the expected behavior in launchable for the PR branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reverted this change so that we can merge this PR without needing additional checks. I was not sure, looking at launchable's UI, how to go about checking. So rather than make a breaking change it is best to merge the other changes, which give us a significant benefit and look at more filtering later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see now launchable output in the CI
one of the CI output
Launchable recorded tests for build 8400631701 (test session 2749801) to workspace vitess/vitess-app from 1 files:
| Files found | Tests found | Tests passed | Tests failed | Total duration (min) |
|---------------|---------------|----------------|----------------|------------------------|
| 1 | 16 | 16 | 0 | 3.15 |
Signed-off-by: Rohit Nayak <[email protected]>
Description
The CI output is pretty large for some workflows, especially the unit test ones which log 16MB and 150K lines. This PR reduces it to mainly make it easier to find failing logs . Also, it takes a while for the logs to load online, to cut/paste and IDE complains because of the large size.
Results of
wc
on the raw logs of the 8.0 unit test before and after the PR:Following changes have been made:
apt-get -qq
curl -s
wget-retry -q
So totally about 50% reduction in unit test logs. The first set of improvements should apply across the board since all tests will get dependencies.
Reverted changes to test output filtering
I originally did this and reverted because I was not able to navigate the launchable UI to check any impact.
Reverted change:
cat output.txt | grep -ivE '(PASS|RUN).*(Collation|Test.*Valid|TestRemoteWildcardMatches|Fuzz|tpcc|TestParse|PITR|cases|TestPlan|Super.*long)|DBClient'
Related Issue(s)
Checklist
Deployment Notes