-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docs for unmanaged tablets #15437
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
added
Type: Documentation
Component: Documentation
docs related issues/PRs
labels
Mar 11, 2024
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Mar 11, 2024
GuptaManan100
added
Backport to: release-17.0
Backport to: release-19.0
Needs to be back ported to release-19.0
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Mar 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15437 +/- ##
==========================================
- Coverage 65.64% 65.63% -0.01%
==========================================
Files 1562 1562
Lines 194318 194318
==========================================
- Hits 127553 127545 -8
- Misses 66765 66773 +8 ☔ View full report in Codecov by Sentry. |
This was referenced Mar 13, 2024
Closed
Closed
Closed
shlomi-noach
approved these changes
Mar 13, 2024
systay
approved these changes
Mar 13, 2024
vitess-bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
vitess-bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
systay
pushed a commit
that referenced
this pull request
Mar 13, 2024
systay
pushed a commit
that referenced
this pull request
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport to: release-19.0
Needs to be back ported to release-19.0
Component: Documentation
docs related issues/PRs
Type: Documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@deepthi noticed and pointed out that the docs for unmanaged tablets still listed
enable_replication_reporter
flag. The docs said that this flag would make vttablets repair its own replication, but this hasn't been true since v16.0.0.This PR fixes the docs and should be backported to all the releases that are affected by the same problem.
Related Issue(s)
Checklist
Deployment Notes