-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VTOrc optimize TMC usage #15356
Merged
GuptaManan100
merged 2 commits into
vitessio:main
from
planetscale:vtorc-optimize-tmc-usage
Feb 27, 2024
Merged
VTOrc optimize TMC usage #15356
GuptaManan100
merged 2 commits into
vitessio:main
from
planetscale:vtorc-optimize-tmc-usage
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
added
Type: Feature
Component: VTorc
Vitess Orchestrator integration
labels
Feb 26, 2024
GuptaManan100
requested review from
ajm188,
rohit-nayak-ps,
shlomi-noach and
deepthi
as code owners
February 26, 2024 10:47
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Feb 26, 2024
GuptaManan100
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Feb 26, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15356 +/- ##
==========================================
- Coverage 67.41% 65.42% -2.00%
==========================================
Files 1560 1561 +1
Lines 192752 193529 +777
==========================================
- Hits 129952 126615 -3337
- Misses 62800 66914 +4114 ☔ View full report in Codecov by Sentry. |
deepthi
approved these changes
Feb 26, 2024
mattlord
approved these changes
Feb 26, 2024
GuptaManan100
added
the
Backport to: release-19.0
Needs to be back ported to release-19.0
label
Apr 19, 2024
GuptaManan100
added a commit
to planetscale/vitess
that referenced
this pull request
Apr 19, 2024
Signed-off-by: Manan Gupta <[email protected]>
deepthi
pushed a commit
that referenced
this pull request
Apr 19, 2024
Signed-off-by: Manan Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport to: release-19.0
Needs to be back ported to release-19.0
Component: VTorc
Vitess Orchestrator integration
Type: Feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the feature requested in #15355.
Similar changes to the
CheckThrottler
RPC had been made in #14979. This PR replicates them forFullStatus
RPC. While working on this, a few more refactoring changes have been made to make the code more uniform.Related Issue(s)
Checklist
Deployment Notes