-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve VTOrc startup flow #15315
Improve VTOrc startup flow #15315
Conversation
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
@@ -64,16 +65,24 @@ func RegisterFlags(fs *pflag.FlagSet) { | |||
// OpenTabletDiscovery opens the vitess topo if enables and returns a ticker | |||
// channel for polling. | |||
func OpenTabletDiscovery() <-chan time.Time { | |||
// TODO(sougou): If there's a shutdown signal, we have to close the topo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed this too because it was really just 1 line fix, involving adding ts.Close()
to closeVTOrc
Signed-off-by: Manan Gupta <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #15315 +/- ##
==========================================
+ Coverage 67.53% 67.62% +0.08%
==========================================
Files 1561 1561
Lines 193387 193392 +5
==========================================
+ Hits 130607 130778 +171
+ Misses 62780 62614 -166 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Manan Gupta <[email protected]>
Description
This PR makes the changes requested in #15314.
This PR removes the wait period from VTOrc. Also, I noticed that the topo tick that we use to load all the information doesn't trigger immediately. So, in this PR, during the starting phase of VTOrc, we make it populate all the information once in the beginning. And then we can start checking and recovering failures without needing the wait period we had before.
An additional benefit of the changes in this PR is that when VTOrc displays itself as healthy in the
/debug/healthy
API, then it is actually ready to run recoveries, which wasn't true before.Related Issue(s)
Checklist
Deployment Notes