New unified internal table names format: part 2, generating new names #15178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <[email protected]>
shlomi-noach
requested review from
rohit-nayak-ps,
mattlord and
deepthi
as code owners
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
shlomi-noach
added
Type: Internal Cleanup
Component: TabletManager
Component: Online DDL
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #15178 +/- ##
==========================================
- Coverage 70.63% 67.37% -3.27%
==========================================
Files 1377 1560 +183
Lines 182801 192773 +9972
==========================================
+ Hits 129127 129876 +749
- Misses 53674 62897 +9223 ☔ View full report in Codecov by Sentry. |
|
Good to review. |
dbussink
approved these changes
Feb 12, 2024
mattlord
approved these changes
Feb 12, 2024
| // If uuid is given, then it must be in condensed-UUID format. If empty, the function auto-generates a UUID. | ||
| func GenerateInternalTableName(hint string, uuid string, t time.Time) (tableName string, err error) { | ||
| if len(hint) != 3 { | ||
| return "", fmt.Errorf("Invalid hint: %s, expected 3 characters", hint) |
There was a problem hiding this comment.
Any reason not to use vterrors here so that we have codes? IIRC you added some error handling not too long ago that relied on error codes. Error messages also aren't supposed to be capitalized (for wrapping).
There was a problem hiding this comment.
go/vt/schema/name_test.go
Outdated
| assert.NoError(t, err) | ||
|
|
||
| readableTimestamp := ToReadableTimestamp(ti) | ||
| assert.Equal(t, readableTimestamp, "20150225110639") |
There was a problem hiding this comment.
I think it would be more meaningful if we didn't use a string literal here but instead used ti here.
There was a problem hiding this comment.
The point was to validate that a transformation of ti lands at an expected value. So that constant should remain IMO. I did, however, switch between readableTimestamp and "20150225110639" because the constant is the expected one.
go/vt/schema/tablegc.go
Outdated
Comment on lines
48
to
59
| switch s { | ||
| case HoldTableGCState: | ||
| return InternalTableGCHoldHint | ||
| case PurgeTableGCState: | ||
| return InternalTableGCPurgeHint | ||
| case EvacTableGCState: | ||
| return InternalTableGCEvacHint | ||
| case DropTableGCState: | ||
| return InternalTableGCDropHint | ||
| default: | ||
| return InternalTableUnknownHint | ||
| } |
There was a problem hiding this comment.
Any reason not to make a map of these states like protobuf does? Not a big deal, but the use of Internal (capital I) and Hint here are not obvious to the average reader (me).
Signed-off-by: Shlomi Noach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the 2nd part of introducing the new vitess internal table names. This PR is post
v19, and will be merged inv20.In this PR, we still support both old name format and new name format. However, we now generate internal table names in new format only. This means:
_vt_hld_6ace8bcef73211ea87e9f875a4d24e90_20200915120410__vt_vrp_6ace8bcef73211ea87e9f875a4d24e90_20200915120410_Some implementation notes:
InternalTableHint, which is also used inTableGCState"_vrepl"table name by itself, directly; now it usesgo/vt/schemato do so.v21we will remove them.gh-osttable names andpt-osctable names are unaffected by this change.gh-ostis a bit of a problem because there's no way right now to force it to accept the new naming format. We could updategh-ost, but then don't really have control over thegh-ostversion the user chooses to install. Also, we're moving away fromgh-ostand so it's not as important. This is a discussion for another issue.Related Issue(s)
Checklist
Deployment Notes