-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use collation aware typing for UNION #15122
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #15122 +/- ##
===========================================
+ Coverage 47.29% 70.64% +23.34%
===========================================
Files 1137 1376 +239
Lines 238684 182454 -56230
===========================================
+ Hits 112895 128886 +15991
+ Misses 117168 53568 -63600
+ Partials 8621 0 -8621 ☔ View full report in Codecov by Sentry. |
Missing tests? ;) |
👍🏻 |
b6c8816
to
8af166c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Paired with Andres on this
Hopefully this can make it before the code freeze. 🚀 |
935591c
to
1d96548
Compare
I've moved the bug fixing to a different PR: #15134. We want to backport the bug fixes, but not this new type aggregating. |
1d96548
to
61f4859
Compare
61f4859
to
032def4
Compare
Signed-off-by: Andres Taylor <[email protected]>
032def4
to
742b254
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ it
Description
A bug was recently solved (#15069) that fixes the type copying to UNION columns. We want to backport this fix, so it didn't contain support for collations. In earlier releases we don't have this capability.
In
main
we now have a way to aggregate the types including the collation of the columns (#15085), so here is the update that uses this new way of aggregating types.Related Issue(s)
Original issue: #15020
Checklist