-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests for the vt/logz package #15060
Conversation
Signed-off-by: VaibhavMalik4187 <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
@systay could you please review this PR whenever you have a moment? Thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15060 +/- ##
==========================================
+ Coverage 47.49% 47.54% +0.05%
==========================================
Files 1149 1150 +1
Lines 239475 239614 +139
==========================================
+ Hits 113730 113918 +188
+ Misses 117138 117092 -46
+ Partials 8607 8604 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This commit increases the code coverage of the
go/vt/logz
package to 100%.Related Issue(s)
Partially Addresses: #14931
Checklist