-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests for the go/vt/callinfo package #15059
Conversation
Signed-off-by: VaibhavMalik4187 <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15059 +/- ##
==========================================
+ Coverage 47.49% 47.51% +0.01%
==========================================
Files 1149 1152 +3
Lines 239475 239539 +64
==========================================
+ Hits 113730 113807 +77
+ Misses 117138 117122 -16
- Partials 8607 8610 +3 ☔ View full report in Codecov by Sentry. |
@GuptaManan100 could you please go through this PR whenever you have some spare time? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for reviewing. |
Description
This commit increases the code coverage of the
go/vt/callinfo
package to >74%Related Issue(s)
#14931
Checklist