Added missing tests for the sqltypes package #15056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VaibhavMalik4187
requested review from
harshit-gangal,
shlomi-noach and
vmg
as code owners
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15056 +/- ##
==========================================
+ Coverage 47.72% 47.76% +0.03%
==========================================
Files 1155 1155
Lines 240264 240264
==========================================
+ Hits 114665 114754 +89
+ Misses 116996 116919 -77
+ Partials 8603 8591 -12 ☔ View full report in Codecov by Sentry. |
go/sqltypes/named_result_test.go
Outdated
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| val, err := row.ToInt(tt.fieldName) | ||
| if val == 0 { |
There was a problem hiding this comment.
The check for whether there should be an error or not, shouldn't be defined by the result from the function you're testing. It should be inferred from the test configuration. So, instead we should use if tt.expectedErr != "". This same comment stands for subsequent checks as well.
vmg
approved these changes
Jan 29, 2024
vmg
added
Component: Build/CI
Type: Testing
and removed
NeedsDescriptionUpdate
VaibhavMalik4187
force-pushed
the
sqltypes-tests
branch
from
fe56725 to
def7451
Compare
dbussink
reviewed
Jan 29, 2024
go/sqltypes/named_result_test.go
Outdated
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| _, err := row.ToInt(tt.fieldName) | ||
| if tt.expectedInt == 0 { |
There was a problem hiding this comment.
Same here, we should be checking tt.expectedErr instead. Like what if the value really is 0 for example?
There was a problem hiding this comment.
Right, it makes more sense to check using expectedErr. Thanks for pointing this out. I've updated the code.
Signed-off-by: VaibhavMalik4187 <[email protected]>
VaibhavMalik4187
force-pushed
the
sqltypes-tests
branch
from
def7451 to
f06b63c
Compare
dbussink
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit increases the code coverage of the
go/sqltypespackage to 62%.Related Issue(s)
Partially addresses: #14931
Checklist