Fixed bug in flagutil package and added tests #15046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15046 +/- ##
==========================================
+ Coverage 47.49% 47.54% +0.04%
==========================================
Files 1149 1149
Lines 239387 239325 -62
==========================================
+ Hits 113692 113778 +86
+ Misses 117102 116959 -143
+ Partials 8593 8588 -5 ☔ View full report in Codecov by Sentry. |
VaibhavMalik4187
force-pushed
the
flagutil-tests
branch
from
ef0a23d to
1ec7f05
Compare
|
@systay could you please go through this PR during your spare time? Thanks :) |
ajm188
reviewed
Jan 27, 2024
go/flagutil/enum_test.go
Outdated
| ) | ||
|
|
||
| func TestNewStringEnumCaseSensitive(t *testing.T) { | ||
| enum := NewStringEnum("fruits enum", "Mango", []string{"apple", "Mango"}) |
There was a problem hiding this comment.
Why not fold these functions in as test cases in the TestStringEnum test function?
There was a problem hiding this comment.
Done, thanks for the suggestion.
| }, | ||
| } | ||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { |
There was a problem hiding this comment.
You need to capture the tt variable within the loop. See this for an example/explainer
There was a problem hiding this comment.
Understood, done.
| choices: choiceMap, | ||
| choiceNames: choiceNames, | ||
| choiceMapper: choiceMapper, | ||
| caseInsensitive: caseInsensitive, |
Signed-off-by: VaibhavMalik4187 <[email protected]>
VaibhavMalik4187
force-pushed
the
flagutil-tests
branch
from
1ec7f05 to
079d302
Compare
ajm188
approved these changes
Jan 27, 2024
GuptaManan100
added
Type: Testing
Component: CLI
Component: ACL
and removed
NeedsDescriptionUpdate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug: the
caseInsensitivevariables was not being used inStringEnuminitialization.Fix: Added code to initialize the
caseInsensitivevariable when theStringEnuminstance is created.Added unit tests to increase the code coverage of the
flagutilpackage.Related Issue(s)
Partially addresses: #14931
Checklist