Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more explicit in release notes regarding the deprecation of certain vitess/lite tags #15040

Merged

Conversation

frouioui
Copy link
Member

Description

Small update to the v19.0.0 release notes to inform readers that MySQL/Percona version specific tags are deprecated in v19.0.0.

@frouioui frouioui requested a review from deepthi as a code owner January 25, 2024 20:20
Copy link
Contributor

vitess-bot bot commented Jan 25, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 25, 2024
@frouioui frouioui added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Docker and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 25, 2024
@github-actions github-actions bot added this to the v19.0.0 milestone Jan 25, 2024
@frouioui frouioui requested a review from mattlord January 25, 2024 20:23
Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one small idea/suggestion.

changelog/19.0/19.0.0/summary.md Outdated Show resolved Hide resolved
Co-authored-by: Matt Lord <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 435 lines in your changes are missing coverage. Please review.

Comparison is base (eddb39e) 47.29% compared to head (d3cce7b) 47.49%.
Report is 72 commits behind head on main.

❗ Current head d3cce7b differs from pull request most recent head 8820dc9. Consider uploading reports for the commit 8820dc9 to get more accurate results

Files Patch % Lines
...vt/vtgate/planbuilder/operators/sharded_routing.go 0.00% 42 Missing ⚠️
go/vt/vtgate/semantics/early_rewriter.go 86.41% 23 Missing and 10 partials ⚠️
go/vt/vtgate/planbuilder/operators/delete.go 0.00% 32 Missing ⚠️
.../vtgate/planbuilder/operators/delete_with_input.go 0.00% 31 Missing ⚠️
go/vt/vtgate/engine/delete_with_input.go 53.70% 23 Missing and 2 partials ⚠️
...tgate/planbuilder/operators/aggregation_pushing.go 0.00% 25 Missing ⚠️
...vt/vtgate/planbuilder/operators/queryprojection.go 0.00% 20 Missing ⚠️
.../vt/vtgate/planbuilder/operators/query_planning.go 0.00% 19 Missing ⚠️
go/vt/vtgate/evalengine/expr_tuple_bvar.go 62.50% 14 Missing and 4 partials ⚠️
go/vt/vtgate/planbuilder/operators/phases.go 0.00% 16 Missing ⚠️
... and 45 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15040      +/-   ##
==========================================
+ Coverage   47.29%   47.49%   +0.19%     
==========================================
  Files        1137     1149      +12     
  Lines      238684   239387     +703     
==========================================
+ Hits       112895   113700     +805     
+ Misses     117168   117096      -72     
+ Partials     8621     8591      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frouioui frouioui requested a review from ajm188 January 29, 2024 13:57
@frouioui frouioui merged commit c09ede9 into vitessio:main Jan 29, 2024
100 checks passed
@frouioui frouioui deleted the fix-mysqld-deprecation-release-notes branch January 29, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Docker Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants