Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evalengine: Implement LAST_DAY #15038

Merged
merged 4 commits into from
Jan 26, 2024

Add check for IsZero datetime in Fn_LAST_DAY

c24efc8
Select commit
Loading
Failed to load commit list.
Merged

evalengine: Implement LAST_DAY #15038

Add check for IsZero datetime in Fn_LAST_DAY
c24efc8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 26, 2024 in 0s

47.49% (+0.13%) compared to 1bf8dda

View this Pull Request on Codecov

47.49% (+0.13%) compared to 1bf8dda

Details

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (1bf8dda) 47.36% compared to head (c24efc8) 47.49%.
Report is 19 commits behind head on main.

Files Patch % Lines
go/vt/vtgate/evalengine/cached_size.go 0.00% 10 Missing ⚠️
go/vt/vtgate/evalengine/compiler_asm.go 71.42% 3 Missing and 1 partial ⚠️
go/vt/vtgate/evalengine/fn_time.go 92.50% 2 Missing and 1 partial ⚠️
go/vt/vtgate/evalengine/translate_builtin.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15038      +/-   ##
==========================================
+ Coverage   47.36%   47.49%   +0.13%     
==========================================
  Files        1144     1149       +5     
  Lines      238995   239387     +392     
==========================================
+ Hits       113197   113700     +503     
+ Misses     117213   117092     -121     
- Partials     8585     8595      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov