-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix panic for unknown columns in foreign key managed mode #15025
Conversation
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
This PR needs to be backported to release-18.0 because the panic exists there as well. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #15025 +/- ##
==========================================
+ Coverage 47.33% 47.35% +0.02%
==========================================
Files 1142 1144 +2
Lines 239009 239077 +68
==========================================
+ Hits 113125 113225 +100
+ Misses 117289 117258 -31
+ Partials 8595 8594 -1 ☔ View full report in Codecov by Sentry. |
Description
This PR fixes the bug specified in #15024. Instead of panicking vtgate, it is better to return a more readable error so that users can resolve it.
Related Issue(s)
Checklist
Deployment Notes