Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-17.0] 17.0.6 release notes: ExecuteFetchAsDBA breaking change #15011

Merged
merged 5 commits into from
Jan 24, 2024
Merged

[release-17.0] 17.0.6 release notes: ExecuteFetchAsDBA breaking change #15011

merged 5 commits into from
Jan 24, 2024

Conversation

shlomi-noach
Copy link
Contributor

Description

release-17.0: Documenting the breaking change in #14983

Related Issue(s)

#14983

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach shlomi-noach added Type: Documentation release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) Component: Documentation docs related issues/PRs labels Jan 23, 2024
@shlomi-noach shlomi-noach requested a review from deepthi as a code owner January 23, 2024 09:43
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Jan 23, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 23, 2024
@shlomi-noach
add changelog file
34af9e3 
Signed-off-by: Shlomi Noach <[email protected]>
@github-actions github-actions bot added this to the v17.0.6 milestone Jan 23, 2024
@shlomi-noach
releases
7ed5d94 
Signed-off-by: Shlomi Noach <[email protected]>
@frouioui frouioui removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 23, 2024
frouioui
frouioui reviewed Jan 23, 2024
View reviewed changes
changelog/17.0/17.0.6/changelog.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as https://github.com/vitessio/vitess/pull/15012/files#r1463325449

@shlomi-noach
summary.md
f776e9a 
Signed-off-by: Shlomi Noach <[email protected]>
@shlomi-noach shlomi-noach removed the release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) label Jan 23, 2024
deepthi
deepthi approved these changes Jan 24, 2024
View reviewed changes
changelog/17.0/17.0.6/summary.md Outdated Show resolved Hide resolved
@shlomi-noach @deepthi
Update changelog/17.0/17.0.6/summary.md
f547fc6 
Co-authored-by: Deepthi Sigireddi <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
@shlomi-noach shlomi-noach merged commit 85b764d into vitessio:release-17.0 Jan 24, 2024
101 checks passed
@shlomi-noach shlomi-noach deleted the release-notes-executefetch-as-dba-17-0 branch January 24, 2024 08:54
@shlomi-noach
Copy link
Contributor Author

Do we need to cherry pick this into main?

@shlomi-noach
Copy link
Contributor Author

@frouioui for authoritative answer.

@shlomi-noach
Copy link
Contributor Author

Answer: it will be done automatically during the next patch release on 17.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@deepthi deepthi deepthi approved these changes

Assignees
No one assigned
Labels
Component: Documentation docs related issues/PRs Type: Documentation
Projects
None yet
Milestone
v17.0.6
Development

Successfully merging this pull request may close these issues.
3 participants
@shlomi-noach @deepthi @frouioui