-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vtgate: increment vtgate_warnings counter for non atomic commits #15010
Merged
harshit-gangal
merged 1 commit into
vitessio:main
from
planetscale:maxeng-inc-warnings-nonatomiccommit
Jan 25, 2024
Merged
vtgate: increment vtgate_warnings counter for non atomic commits #15010
harshit-gangal
merged 1 commit into
vitessio:main
from
planetscale:maxeng-inc-warnings-nonatomiccommit
Jan 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Englander <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Jan 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15010 +/- ##
=======================================
Coverage 47.36% 47.37%
=======================================
Files 1144 1144
Lines 238995 238996 +1
=======================================
+ Hits 113197 113215 +18
+ Misses 117213 117196 -17
Partials 8585 8585 ☔ View full report in Codecov by Sentry. |
maxenglander
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: Query Serving
Component: Observability
Pull requests that touch tracing/metrics/monitoring
and removed
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Jan 22, 2024
maxenglander
requested review from
harshit-gangal,
systay,
frouioui and
GuptaManan100
as code owners
January 22, 2024 21:33
deepthi
changed the title
vtgate: increment vtgate_warnings for non atomic commts
vtgate: increment vtgate_warnings counter for non atomic commits
Jan 25, 2024
deepthi
approved these changes
Jan 25, 2024
deepthi
removed
the
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
label
Jan 25, 2024
5 tasks
harshit-gangal
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Observability
Pull requests that touch tracing/metrics/monitoring
Component: Query Serving
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change was supposed to get merged with #14848 but it looks like I never pushed it up 😮💨
Related Issue(s)
#14848
#14815
Checklist
Deployment Notes