Use the correct parser for truncation #14985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was broken in the parser injection refactor and this didn't inject the properly configured object. Also cleans up some global init() calls as well and moves it to the pattern of how we initialize the rest which we need to pass in the parser correctly anyway. Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink
requested review from
harshit-gangal,
systay,
shlomi-noach,
rohit-nayak-ps,
frouioui and
GuptaManan100
as code owners
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
shlomi-noach
approved these changes
Jan 18, 2024
dbussink
commented
Jan 18, 2024
| @@ -55,10 +55,9 @@ var ( | |||
| </thead> | |||
| `) | |||
| querylogzFuncMap = template.FuncMap{ | |||
| "stampMicro": func(t time.Time) string { return t.Format(time.StampMicro) }, | |||
| "cssWrappable": logz.Wrappable, | |||
| "truncateQuery": sqlparser.NewTestParser().TruncateForUI, | |||
There was a problem hiding this comment.
sqlparser.NewTestParser() is the problematic bit here, I did that to then revisit later but I missed that 🤦
dbussink
added
Type: Bug
Component: General
systay
approved these changes
Jan 18, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #14985 +/- ##
=======================================
Coverage 47.29% 47.30%
=======================================
Files 1139 1139
Lines 238914 238918 +4
=======================================
+ Hits 113004 113018 +14
+ Misses 117315 117308 -7
+ Partials 8595 8592 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken in the parser injection refactor and this didn't inject the properly configured object.
Also cleans up some global init() calls as well and moves it to the pattern of how we initialize the rest which we need to pass in the parser correctly anyway.
Related Issue(s)
Should have been done in #14822 as part of work on #14717
Checklist