Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required tests for go/mysql/hex #14976

Merged
merged 5 commits into from
Jan 18, 2024
Merged

Add required tests for go/mysql/hex #14976

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
db48a8f
Add required tests for go/mysql/hex
beingnoble03 Jan 17, 2024
ecb3b2d
Replace assert.Errorf with assert.Error with no message
beingnoble03 Jan 18, 2024
0c4252c
Replace assert.Errorf with assert.Error
beingnoble03 Jan 18, 2024
fc8d15b
Add error message in assert.Error
beingnoble03 Jan 18, 2024
76ef13a
Remove the custom message from assert.Error
beingnoble03 Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/mysql/hex/hex_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,5 +98,5 @@ func TestDecodeBytes(t *testing.T) {
// DecodeBytes should return an error for "é" as
// hex.decode returns an error for non-ASCII characters
err = DecodeBytes([]byte("testDst"), []byte("é"))
assert.Error(t, err)
assert.Error(t, err, "DecodeBytes() should have errored as src contains non-ASCII character")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for having a custom message at all?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have added custom messages earlier in other tests too. So, I added here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think it add a lot of value here? I think we can go for the minimal setup and only add something custom if there’s explicit value in doing so.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

}
Loading