Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unit test for go/sets/set.go #14973

Merged
merged 5 commits into from
Jan 25, 2024
Merged

unit test for go/sets/set.go #14973

merged 5 commits into from
Jan 25, 2024

Conversation

Its-Maniaco
Copy link
Contributor

@Its-Maniaco Its-Maniaco commented Jan 17, 2024 •
edited
Loading

Partial Fix to #14931

Covers unit test for go/sets/set.go

image

ok vitess.io/vitess/go/sets 0.011s coverage: 73.8% of statements

@Its-Maniaco Its-Maniaco requested a review from deepthi as a code owner January 17, 2024 12:34
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Jan 17, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 17, 2024
@github-actions github-actions bot added this to the v19.0.0 milestone Jan 17, 2024
@frouioui frouioui added Type: Testing Component: General Changes throughout the code base and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 17, 2024
frouioui
frouioui reviewed Jan 17, 2024
View reviewed changes
go/sets/set_test.go
Comment on lines +1 to +21
package sets

import (
"testing"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license header is missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

@mattlord mattlord mentioned this pull request Jan 17, 2024
Open
@Its-Maniaco
Copy link
Contributor Author

I can edit the comments and add further test if this looks fine.

dbussink
dbussink reviewed Jan 18, 2024
View reviewed changes
go/sets/set_test.go Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Jan 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (17e7f84) 47.38% compared to head (bf77227) 47.42%.
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14973      +/-   ##
==========================================
+ Coverage   47.38%   47.42%   +0.03%     
==========================================
  Files        1145     1147       +2     
  Lines      239155   239260     +105     
==========================================
+ Hits       113322   113458     +136     
+ Misses     117249   117217      -32     
- Partials     8584     8585       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dbussink
dbussink reviewed Jan 24, 2024
View reviewed changes
go/sets/set_test.go Outdated
compareSet.Insert(-1, -2)
assert.False(t, testSet.Equal(compareSet))

//tests for Difference func
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A single test should ideally test a single function. So I think this should be a bunch of separate tests and not one big test function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bundled all of them since all of the functions were operations being done on a Set.

@dbussink
Copy link
Contributor

@Its-Maniaco Looks like the DCO check is failing, can you make sure the commits have the correct signed-off messages and update the PR?

@Its-Maniaco
broke the test in pieces
952c5fb 
Signed-off-by: Divya Pamecha <[email protected]>
GuptaManan100
GuptaManan100 reviewed Jan 25, 2024
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me now! What is the test coverage for this package post the changes?

@Its-Maniaco
Copy link
Contributor Author

ok vitess.io/vitess/go/sets (cached) coverage: 78.6% of statements

@GuptaManan100
Copy link
Member

GuptaManan100 commented Jan 25, 2024 •
edited
Loading

@Its-Maniaco I have pushed a commit to make the test coverage 100%. This should be good to be merged now. Just waiting for the tests to be green.

@GuptaManan100 GuptaManan100 merged commit e647a2d into vitessio:main Jan 25, 2024
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbussink dbussink dbussink left review comments

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@frouioui frouioui frouioui approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

Assignees
No one assigned
Labels
Component: General Changes throughout the code base Type: Testing
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Its-Maniaco @dbussink @GuptaManan100 @frouioui