-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vtctldclient CLI validation: Add e2e test to check that options to the vtctldclient commands are supported #14957
vtctldclient CLI validation: Add e2e test to check that options to the vtctldclient commands are supported #14957
Conversation
… for MoveTables. One failure to be fixed Signed-off-by: Rohit Nayak <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #14957 +/- ##
==========================================
+ Coverage 47.33% 47.36% +0.03%
==========================================
Files 1142 1142
Lines 239009 239041 +32
==========================================
+ Hits 113125 113215 +90
+ Misses 117289 117232 -57
+ Partials 8595 8594 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I only had minor comments/nits. I'm going to push a commit that addresses them and then approve.
go/test/endtoend/vreplication/vreplication_vtctldclient_cli_test.go
Outdated
Show resolved
Hide resolved
go/test/endtoend/vreplication/vreplication_vtctldclient_cli_test.go
Outdated
Show resolved
Hide resolved
go/test/endtoend/vreplication/vreplication_vtctldclient_cli_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Matt Lord <[email protected]>
…tions-test Signed-off-by: Matt Lord <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @rohit-nayak-ps ! This is a nice addition and shows the way for similar tests in the future.
Description
We are deprecating vtctlclient in favor of vtctldclient. This PR adds more tests around CLI parameters which are not already tested by the existing e2e tests.
Fixes a couple of minor elements missing in the output of Show.
Related Issue(s)
Tests stuff we implemented as part of #12152
Checklist
Deployment Notes