Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExecuteFetchAsDBA(): handle 'allowZeroInDate' and batched queries #14953

Closed

Conversation

shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented Jan 15, 2024

Description

This is a backport-compliant fix for #14952. In this PR:

  • ExecuteFetchAsDBA() correctly identifies the existence of /*vt+ allowZeroInDate=true */ in either a single or a multi statement SQL. However, this is a hacky solution in that it is enough that a single query has this directive, that we apply it to all queries.
  • ExecuteFetchAsDBA() drains the results of a multi-statement SQL, and as effect ReloadSchema loads all tables effected in a multi-statement SQL.

This is backport compliant solution, and so it intentionally does not error when a multi-statement SQL is provided. Technically, it's not the correct mechanism for running multiple queries, because it only returns a single result set.

A followup PR, that will build on top of this one for backwards compatibility reasons, will make proto changes to better formalize multi-statement SQLs as well as the request for a allowZeroInDate friendly connection.

Backport

This should be backported to release-18.0 because --batch-size is included in release-18.0.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented Jan 15, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 15, 2024
@shlomi-noach shlomi-noach requested a review from a team January 15, 2024 13:02
@github-actions github-actions bot added this to the v19.0.0 milestone Jan 15, 2024
@shlomi-noach shlomi-noach added Backport to: release-18.0 and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Jan 15, 2024
@shlomi-noach shlomi-noach marked this pull request as draft January 15, 2024 13:40
@shlomi-noach
Copy link
Contributor Author

Making some edits, will re-publish shortly.

@shlomi-noach
Copy link
Contributor Author

Replaced by #14954

@shlomi-noach shlomi-noach deleted the apply-schema-batch-size-fix branch January 15, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: TabletManager NeedsBackportReason If backport labels have been applied to a PR, a justification is required Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant