-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor out more usage of servenv for mysql version #14938
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbussink
added
Type: Internal Cleanup
Component: General
Changes throughout the code base
labels
Jan 12, 2024
dbussink
requested review from
harshit-gangal,
systay,
frouioui,
GuptaManan100,
arthurschreiber,
ajm188,
notfelineit,
rohit-nayak-ps and
deepthi
as code owners
January 12, 2024 07:47
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Jan 12, 2024
dbussink
force-pushed
the
test-mysql-version-refactor
branch
from
January 12, 2024 09:13
fb4d772
to
0fbcca9
Compare
dbussink
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Jan 12, 2024
dbussink
changed the title
Refactor our more usage of servenv for mysql version
Refactor out more usage of servenv for mysql version
Jan 12, 2024
dbussink
force-pushed
the
test-mysql-version-refactor
branch
3 times, most recently
from
January 12, 2024 13:13
a4a3689
to
494dbd4
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #14938 +/- ##
==========================================
+ Coverage 47.29% 47.31% +0.01%
==========================================
Files 1137 1137
Lines 238684 238718 +34
==========================================
+ Hits 112895 112940 +45
- Misses 117168 117169 +1
+ Partials 8621 8609 -12 ☔ View full report in Codecov by Sentry. |
dbussink
force-pushed
the
test-mysql-version-refactor
branch
from
January 12, 2024 15:06
494dbd4
to
ca20ec6
Compare
dbussink
force-pushed
the
test-mysql-version-refactor
branch
from
January 12, 2024 15:28
ca20ec6
to
c70f74c
Compare
shlomi-noach
approved these changes
Jan 14, 2024
dbussink
force-pushed
the
test-mysql-version-refactor
branch
from
January 14, 2024 14:15
c70f74c
to
d4998f1
Compare
Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink
force-pushed
the
test-mysql-version-refactor
branch
from
January 14, 2024 15:45
d4998f1
to
58731a2
Compare
harshit-gangal
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors out usage of
servenv
inside theevalengine
. This helpsevalengine
be more of a standalone dependency, so it's easier to use and pulls in way fewer dependencies when used as a libraryTransitively this also helps
schemadiff
which ends up usingevalengine
for view semantic analysis and heavily reducesschemadiff
dependencies as well (together with the refactor also done in #14930. This is similar in nature as well as #14822, #14781 & #14732Related Issue(s)
Part of #14717 and when used for https://github.com/planetscale/schemadiff greatly reduces dependencies (and binary size) there.
Checklist