Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor out more usage of servenv for mysql version #14938

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

dbussink
Copy link
Contributor

This refactors out usage of servenv inside the evalengine. This helps evalengine be more of a standalone dependency, so it's easier to use and pulls in way fewer dependencies when used as a library

Transitively this also helps schemadiff which ends up using evalengine for view semantic analysis and heavily reduces schemadiff dependencies as well (together with the refactor also done in #14930. This is similar in nature as well as #14822, #14781 & #14732

Related Issue(s)

Part of #14717 and when used for https://github.com/planetscale/schemadiff greatly reduces dependencies (and binary size) there.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Copy link
Contributor

vitess-bot bot commented Jan 12, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 12, 2024
@github-actions github-actions bot added this to the v19.0.0 milestone Jan 12, 2024
@dbussink dbussink force-pushed the test-mysql-version-refactor branch from fb4d772 to 0fbcca9 Compare January 12, 2024 09:13
@dbussink dbussink removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 12, 2024
@dbussink dbussink changed the title Refactor our more usage of servenv for mysql version Refactor out more usage of servenv for mysql version Jan 12, 2024
@dbussink dbussink force-pushed the test-mysql-version-refactor branch 3 times, most recently from a4a3689 to 494dbd4 Compare January 12, 2024 13:13
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 52 lines in your changes are missing coverage. Please review.

Comparison is base (eddb39e) 47.29% compared to head (58731a2) 47.31%.
Report is 3 commits behind head on main.

Files Patch % Lines
...gate/planbuilder/operators/info_schema_planning.go 0.00% 9 Missing ⚠️
...o/vt/vttablet/tabletmanager/vreplication/engine.go 28.57% 5 Missing ⚠️
go/vt/vtgate/planbuilder/operators/route.go 0.00% 4 Missing ⚠️
go/vt/vtctl/grpcvtctldserver/server.go 40.00% 3 Missing ⚠️
go/vt/vttablet/onlineddl/executor.go 0.00% 3 Missing ⚠️
go/vt/vttablet/tabletserver/schema/engine.go 25.00% 3 Missing ⚠️
go/vt/vttablet/tabletserver/tabletenv/env.go 0.00% 3 Missing ⚠️
go/vt/vtgate/evalengine/expr_env.go 80.00% 2 Missing ⚠️
go/vt/vtgate/planbuilder/operators/insert.go 0.00% 2 Missing ⚠️
go/vt/vtgate/vtgate.go 0.00% 2 Missing ⚠️
... and 13 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14938      +/-   ##
==========================================
+ Coverage   47.29%   47.31%   +0.01%     
==========================================
  Files        1137     1137              
  Lines      238684   238718      +34     
==========================================
+ Hits       112895   112940      +45     
- Misses     117168   117169       +1     
+ Partials     8621     8609      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbussink dbussink force-pushed the test-mysql-version-refactor branch from 494dbd4 to ca20ec6 Compare January 12, 2024 15:06
@dbussink dbussink force-pushed the test-mysql-version-refactor branch from ca20ec6 to c70f74c Compare January 12, 2024 15:28
@dbussink
Copy link
Contributor Author

@codecov
codecov/project — 47.29% (-0.01%) compared to eddb39e

@mattlord Is there maybe some threshold that needs to be configured? This kinda reads like a rounding error / issue of why it failed?

@dbussink dbussink force-pushed the test-mysql-version-refactor branch from c70f74c to d4998f1 Compare January 14, 2024 14:15
@dbussink dbussink force-pushed the test-mysql-version-refactor branch from d4998f1 to 58731a2 Compare January 14, 2024 15:45
@dbussink dbussink merged commit ca4246d into vitessio:main Jan 15, 2024
102 checks passed
@dbussink dbussink deleted the test-mysql-version-refactor branch January 15, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: General Changes throughout the code base Type: Internal Cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants