Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go dependencies #14888

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Update Go dependencies #14888

merged 3 commits into from
Jan 4, 2024

Conversation

dbussink
Copy link
Contributor

@dbussink dbussink commented Jan 4, 2024

Updates a whole bunch of Go dependencies to ensure we have recent versions for the future v19 release.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@dbussink
Update Go dependencies
46d1dc6 
Updates a whole bunch of Go dependencies to ensure we have recent
versions for the future v19 release.

Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink added Type: Internal Cleanup dependencies Pull requests that update a dependency file Component: General Changes throughout the code base labels Jan 4, 2024
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Jan 4, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 4, 2024
@github-actions github-actions bot added this to the v19.0.0 milestone Jan 4, 2024
@dbussink dbussink removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 4, 2024
@dbussink
Update codegen
c8dfd59 
Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink requested a review from notfelineit as a code owner January 4, 2024 14:39
@dbussink
Copy link
Contributor Author

dbussink commented Jan 4, 2024

@GuptaManan100 The test failure here seems legit. I wonder if you would have an idea what causes it? Wonder if it's maybe the GRPC upgrade that changes behavior slightly if connections get torn down or something along those lines?

@dbussink
Copy link
Contributor Author

dbussink commented Jan 4, 2024

@GuptaManan100 The test failure here seems legit. I wonder if you would have an idea what causes it? Wonder if it's maybe the GRPC upgrade that changes behavior slightly if connections get torn down or something along those lines?

Found it, looks like bc2e9c6 should fix it.

frouioui
frouioui approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be awesome to have a CRON job for this :) Looks good to me, thank you!

@frouioui frouioui merged commit 4dd0228 into vitessio:main Jan 4, 2024
99 checks passed
@frouioui frouioui deleted the dbussink/update-go-dependencies-again branch January 4, 2024 16:40
This was referenced Jan 4, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@ajm188 ajm188 ajm188 approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@notfelineit notfelineit Awaiting requested review from notfelineit notfelineit is a code owner

Assignees
No one assigned
Labels
Component: General Changes throughout the code base dependencies Pull requests that update a dependency file Type: Internal Cleanup
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dbussink @ajm188 @frouioui