Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unmanaged tablet flag at vttablet level #14871

Merged
merged 11 commits into from
Mar 14, 2024

feat: address review comments

e957a3b
Select commit
Loading
Failed to load commit list.
Merged

Add unmanaged tablet flag at vttablet level #14871

feat: address review comments
e957a3b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 13, 2024 in 0s

65.64% (-0.01%) compared to f889134

View this Pull Request on Codecov

65.64% (-0.01%) compared to f889134

Details

Codecov Report

Attention: Patch coverage is 81.81818% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 65.64%. Comparing base (f889134) to head (e957a3b).

Files Patch % Lines
go/vt/mysqlctl/mysqld.go 50.00% 3 Missing ⚠️
go/vt/vttablet/tabletserver/tabletenv/config.go 88.88% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14871      +/-   ##
==========================================
- Coverage   65.65%   65.64%   -0.01%     
==========================================
  Files        1563     1563              
  Lines      194395   194427      +32     
==========================================
+ Hits       127627   127632       +5     
- Misses      66768    66795      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.