Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evalengine: Fix week overflow #14859

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

dbussink
Copy link
Contributor

@dbussink dbussink commented Dec 26, 2023

Some of the last days in the year can fall in the first week of the next year. If that happens, there are various modes when we should return 53 as the week number and not week 1 for the next year.

This can always be 53. There are weeks which already contain 53 weeks, but it can never be 54 in those cases as in years with 53 weeks, there's never a last day of the year that falls in the first week of next year. It then always falls in week 53 already.

Related Issue(s)

Fixes #14858

Backporting as this is a straight bug in the calculation and it's trivially easy to fix. There's no risk to this fix either. It also can trigger CI instability if we don't fix it which is a useful reason as well.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Some of the last days in the year can fall in the first week of the next
year. If that happens, there are various modes when we should return 53
as the week number and not week 1 for the next year.

This can always be 53. There are weeks which already contain 53 weeks,
but it can never be 54 in those cases as in years with 53 weeks, there's
never a last day of the year that falls in the first week of next year.
It then always falls in week 53 already.

Signed-off-by: Dirkjan Bussink <[email protected]>
Copy link
Contributor

vitess-bot bot commented Dec 26, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 26, 2023
@dbussink dbussink added Type: Bug Component: Evalengine changes to the evaluation engine and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Dec 26, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Dec 26, 2023
@shlomi-noach shlomi-noach merged commit 04028a9 into vitessio:main Dec 26, 2023
107 checks passed
@dbussink dbussink deleted the dbussink/fix-week-overflow branch December 26, 2023 17:45
GuptaManan100 pushed a commit that referenced this pull request Dec 27, 2023
GuptaManan100 pushed a commit that referenced this pull request Dec 27, 2023
GuptaManan100 added a commit that referenced this pull request Dec 27, 2023
Signed-off-by: Manan Gupta <[email protected]>
Co-authored-by: Dirkjan Bussink <[email protected]>
Co-authored-by: Manan Gupta <[email protected]>
GuptaManan100 added a commit that referenced this pull request Dec 27, 2023
Signed-off-by: Manan Gupta <[email protected]>
Co-authored-by: Dirkjan Bussink <[email protected]>
Co-authored-by: Manan Gupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Evalengine changes to the evaluation engine Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Week calculation off for 2023-12-31
3 participants