-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
evalengine: Fix week overflow #14859
Merged
shlomi-noach
merged 1 commit into
vitessio:main
from
dbussink:dbussink/fix-week-overflow
Dec 26, 2023
Merged
evalengine: Fix week overflow #14859
shlomi-noach
merged 1 commit into
vitessio:main
from
dbussink:dbussink/fix-week-overflow
Dec 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the last days in the year can fall in the first week of the next year. If that happens, there are various modes when we should return 53 as the week number and not week 1 for the next year. This can always be 53. There are weeks which already contain 53 weeks, but it can never be 54 in those cases as in years with 53 weeks, there's never a last day of the year that falls in the first week of next year. It then always falls in week 53 already. Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink
requested review from
harshit-gangal,
systay,
frouioui,
GuptaManan100 and
mattlord
as code owners
December 26, 2023 15:37
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Dec 26, 2023
dbussink
added
Type: Bug
Component: Evalengine
changes to the evaluation engine
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Dec 26, 2023
mattlord
approved these changes
Dec 26, 2023
shlomi-noach
approved these changes
Dec 26, 2023
This was referenced Dec 26, 2023
GuptaManan100
pushed a commit
that referenced
this pull request
Dec 27, 2023
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
pushed a commit
that referenced
this pull request
Dec 27, 2023
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
added a commit
that referenced
this pull request
Dec 27, 2023
Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Dirkjan Bussink <[email protected]> Co-authored-by: Manan Gupta <[email protected]>
GuptaManan100
added a commit
that referenced
this pull request
Dec 27, 2023
Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Dirkjan Bussink <[email protected]> Co-authored-by: Manan Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the last days in the year can fall in the first week of the next year. If that happens, there are various modes when we should return 53 as the week number and not week 1 for the next year.
This can always be 53. There are weeks which already contain 53 weeks, but it can never be 54 in those cases as in years with 53 weeks, there's never a last day of the year that falls in the first week of next year. It then always falls in week 53 already.
Related Issue(s)
Fixes #14858
Backporting as this is a straight bug in the calculation and it's trivially easy to fix. There's no risk to this fix either. It also can trigger CI instability if we don't fix it which is a useful reason as well.
Checklist