Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Table Delete Planner Support #14855

Merged
merged 11 commits into from
Jan 3, 2024
Merged

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Dec 24, 2023

Description

This PR enables performing delete on a single sharded table with multiple tables join.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@harshit-gangal harshit-gangal added Type: Feature Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving labels Dec 24, 2023
Copy link
Contributor

vitess-bot bot commented Dec 24, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 24, 2023
@harshit-gangal harshit-gangal removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Dec 24, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Dec 24, 2023
@harshit-gangal harshit-gangal force-pushed the multi-tbl-delete branch 2 times, most recently from 0a9d957 to e34e274 Compare December 27, 2023 16:12
@harshit-gangal harshit-gangal changed the title Multi Table Delete Planning Multi Table Delete Planner Support Dec 28, 2023
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM!

go/vt/vtgate/planbuilder/operators/query_planning.go Outdated Show resolved Hide resolved
@frouioui frouioui merged commit 0467851 into vitessio:main Jan 3, 2024
99 checks passed
@frouioui frouioui deleted the multi-tbl-delete branch January 3, 2024 15:40
@harshit-gangal harshit-gangal mentioned this pull request Feb 20, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature) Type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Multi Table Delete Support
3 participants