Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throttler: refactor global configuration setting as throttler member #14853

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented Dec 22, 2023

Description

Following recurring race condition failures, e.g. https://github.com/vitessio/vitess/actions/runs/7299836104/job/19894003119?pr=14851, this PR removes the global throttler configuration Instance, and makes it a member of the throttler struct. Each throttler has its own dedicated config settings now.

This eliminates race conditions in the unit tests, and generally plays nicer with unit testing.

Related Issue(s)

Closes #14852

Fixes: #14776

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach shlomi-noach added Type: Enhancement Logical improvement (somewhere between a bug and feature) Type: Testing Component: Throttler labels Dec 22, 2023
Copy link
Contributor

vitess-bot bot commented Dec 22, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 22, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Dec 22, 2023
@shlomi-noach
Copy link
Contributor Author

Let's run Unit Test (Race) tests several times in this PR.

@shlomi-noach shlomi-noach requested a review from a team December 22, 2023 16:00
@mattlord
Copy link
Contributor

Let's run Unit Test (Race) tests several times in this PR.

Sounds good! I usually try to do 15-20 in similar PRs (that seems to be pretty representative in my anecdotal experience). We can collectively hit the re-run button here: https://github.com/vitessio/vitess/actions/runs/7301655630/job/19898750909?pr=14853

@shlomi-noach shlomi-noach removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Dec 22, 2023
@shlomi-noach
Copy link
Contributor Author

Noting that there is no backport to this PR.

@shlomi-noach
Copy link
Contributor Author

Related/unrelated, TestSuspendableTickerTick are also flaky. Will fix in a different PR though.

@shlomi-noach shlomi-noach merged commit d072adb into vitessio:main Dec 26, 2023
106 of 108 checks passed
@shlomi-noach shlomi-noach deleted the throttler-config-non-global branch December 26, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Throttler Type: Enhancement Logical improvement (somewhere between a bug and feature) Type: Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table throttler: unit test race condition Flaky Test: TestProbesWhileOperating in Unit Test (Race)
3 participants