-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throttler: refactor global configuration setting as throttler member #14853
Throttler: refactor global configuration setting as throttler member #14853
Conversation
Signed-off-by: Shlomi Noach <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Let's run |
Sounds good! I usually try to do 15-20 in similar PRs (that seems to be pretty representative in my anecdotal experience). We can collectively hit the re-run button here: https://github.com/vitessio/vitess/actions/runs/7301655630/job/19898750909?pr=14853 |
Noting that there is no backport to this PR. |
Related/unrelated, |
Description
Following recurring race condition failures, e.g. https://github.com/vitessio/vitess/actions/runs/7299836104/job/19894003119?pr=14851, this PR removes the global throttler configuration Instance, and makes it a member of the throttler struct. Each throttler has its own dedicated config settings now.
This eliminates race conditions in the unit tests, and generally plays nicer with unit testing.
Related Issue(s)
Closes #14852
Fixes: #14776
Checklist
Deployment Notes