Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schemadiff: allow char->varchar FK reference type matching #14849

Merged
merged 1 commit into from
Dec 22, 2023
Merged

schemadiff: allow char->varchar FK reference type matching #14849

merged 1 commit into from
Dec 22, 2023

Conversation

shlomi-noach
Copy link
Contributor

Description

Followup and adjustment to #14751. Per https://dev.mysql.com/doc/refman/8.0/en/create-table-foreign-keys.html:

The length of string types need not be the same. For nonbinary (character) string columns, the character set and collation must be the same.

This allows parent(char)->child(varchar) types.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach shlomi-noach requested a review from a team December 21, 2023 21:09
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 21, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 21, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Dec 21, 2023
mattlord
mattlord reviewed Dec 21, 2023
View reviewed changes
go/vt/schemadiff/schema.go
@@ -357,6 +357,9 @@ func (s *Schema) normalize() error {
if child.Type == "char" && parent.Type == "varchar" {
return true
}
if child.Type == "varchar" && parent.Type == "char" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like there’s probably types we can leverage here in the parser?

@mattlord mattlord removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request labels Dec 21, 2023
@dbussink dbussink added Type: Bug Component: Query Serving and removed NeedsWebsiteDocsUpdate What it says NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Dec 21, 2023
@shlomi-noach shlomi-noach merged commit d807985 into vitessio:main Dec 22, 2023
106 of 110 checks passed
@shlomi-noach shlomi-noach deleted the schemadiff-fk-char-varchar branch December 22, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattlord mattlord mattlord approved these changes

@dbussink dbussink dbussink approved these changes

@deepthi deepthi Awaiting requested review from deepthi

Assignees
No one assigned
Labels
Component: Query Serving Type: Bug
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shlomi-noach @dbussink @mattlord