Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subquery inside aggregration function #14844

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Subquery inside aggregration function #14844

merged 2 commits into from
Dec 21, 2023

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Dec 21, 2023 •
edited
Loading

Description

When the subquery operator was introduced it missed the case for handling the subquery inside an aggregation function.
This PR adds support for it.

As per the issue group_concat does not accept more than one argument when evaluated at vtgate. That is still unsupported and is not the cause of regression. The queries reported in the issue would work now.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 21, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 21, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Dec 21, 2023
GuptaManan100
GuptaManan100 approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments through out the code would be helpful, other than that, LGTM

@harshit-gangal harshit-gangal removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Dec 21, 2023
@frouioui frouioui added Backport This is a backport and removed Backport This is a backport labels Dec 21, 2023
@frouioui frouioui merged commit 6841090 into vitessio:main Dec 21, 2023
108 of 111 checks passed
@frouioui frouioui deleted the subquery-inside-aggrfunc branch December 21, 2023 15:04
@vitess-bot vitess-bot bot mentioned this pull request Dec 21, 2023
Merged
harshit-gangal added a commit that referenced this pull request Dec 21, 2023
@harshit-gangal
Subquery inside aggregration function (#14844)
b5cf465 
Signed-off-by: Harshit Gangal <[email protected]>
harshit-gangal added a commit that referenced this pull request Dec 21, 2023
@vitess-bot @harshit-gangal
[release-18.0] Subquery inside aggregration function (#14844) (#14845)
f39adab 
Signed-off-by: Harshit Gangal <[email protected]>
Co-authored-by: Harshit Gangal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@frouioui frouioui frouioui approved these changes

@systay systay Awaiting requested review from systay systay is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Regression
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.

Bug Report: group_concat function sometimes unable to take multiple parameters in vitess 18
3 participants
@harshit-gangal @frouioui @GuptaManan100