-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VReplication: Update singular workflow in traffic switcher #14826
Merged
harshit-gangal
merged 2 commits into
vitessio:main
from
planetscale:vrepl_traffic_switcher_bug
Dec 20, 2023
Merged
VReplication: Update singular workflow in traffic switcher #14826
harshit-gangal
merged 2 commits into
vitessio:main
from
planetscale:vrepl_traffic_switcher_bug
Dec 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Lord <[email protected]>
5 tasks
Signed-off-by: Matt Lord <[email protected]>
mattlord
requested review from
deepthi,
rohit-nayak-ps and
ajm188
as code owners
December 19, 2023 22:35
rohit-nayak-ps
approved these changes
Dec 19, 2023
This was referenced Dec 20, 2023
harshit-gangal
approved these changes
Dec 20, 2023
This was referenced Dec 20, 2023
vitess-bot
pushed a commit
that referenced
this pull request
Dec 20, 2023
Signed-off-by: Matt Lord <[email protected]>
harshit-gangal
pushed a commit
that referenced
this pull request
Dec 20, 2023
…cher (#14826) (#14829) Signed-off-by: Matt Lord <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
harshit-gangal
pushed a commit
that referenced
this pull request
Dec 20, 2023
…cher (#14826) (#14828) Signed-off-by: Matt Lord <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Matt Lord <[email protected]>
harshit-gangal
pushed a commit
that referenced
this pull request
Dec 20, 2023
…cher (#14826) (#14827) Signed-off-by: Matt Lord <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Matt Lord <[email protected]>
ejortegau
pushed a commit
to slackhq/vitess
that referenced
this pull request
Jan 24, 2024
…14826) Signed-off-by: Matt Lord <[email protected]> Signed-off-by: Eduardo J. Ortega U. <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a subset of the changes in #14797 — meant to limit changes, making it safer to backport all the way to v16.
Related Issue(s)
Checklist