Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some logs that are logging excessively on large clusters #14825

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Remove some logs that are logging excessively on large clusters #14825

merged 2 commits into from
Dec 20, 2023

Conversation

rohit-nayak-ps
Copy link
Contributor

Description

Removes logs for "Ignored inapplicable SET" system variables and some throttler logs which generate excessive logs for clusters with large number of shards.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@rohit-nayak-ps rohit-nayak-ps added Type: Internal Cleanup Component: Observability Pull requests that touch tracing/metrics/monitoring labels Dec 19, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Dec 19, 2023
@rohit-nayak-ps rohit-nayak-ps marked this pull request as draft December 19, 2023 21:49
@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review December 20, 2023 07:54
@rohit-nayak-ps rohit-nayak-ps merged commit f8968e7 into vitessio:main Dec 20, 2023
116 checks passed
@rohit-nayak-ps rohit-nayak-ps deleted the rohit/reduce-logs branch December 20, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@dbussink dbussink dbussink approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

Assignees
No one assigned
Labels
Component: Observability Pull requests that touch tracing/metrics/monitoring Type: Internal Cleanup
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rohit-nayak-ps @dbussink @shlomi-noach