Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: don't panic when missing schema information #14787

Merged
merged 2 commits into from
Dec 15, 2023
Merged

bugfix: don't panic when missing schema information #14787

merged 2 commits into from
Dec 15, 2023

Conversation

systay
Copy link
Collaborator

@systay systay commented Dec 15, 2023 •
edited
Loading

Description

When schema tracking is not enabled, column information can be missing for unexpanded derived tables, which leads to the planner not being able to figure out types and dependencies.

Before this change, the semantic analyser would panic on these queries. This change makes it return an error instead.

Related Issue(s)

Fixes #14788

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 15, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 15, 2023
@systay systay added Type: Bug Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Dec 15, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Dec 15, 2023
arthurschreiber
arthurschreiber reviewed Dec 15, 2023
View reviewed changes
go/vt/vtgate/planbuilder/testdata/unsupported_cases.json
{
"comment": "We need schema tracking to allow unexpanded columns inside UNION",
"query": "select x from (select t.*, 0 as x from user t union select t.*, 1 as x from user_extra t) AS t",
"plan": "VT09015: schema tracking required"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this error is not going to happen when schema tracking is disabled but authoritative column data is provided?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is the short hand info that we provide in the error message. In the manual we add a little more detail:

VT09015

This query cannot be planned without more information on the SQL schema. Please turn on schema tracking or add authoritative columns information to your VSchema.

@systay systay force-pushed the derived-unexpanded-table-dont-panic branch from d11206c to 4c4357a Compare December 15, 2023 14:52
@systay systay merged commit 7c9fec7 into vitessio:main Dec 15, 2023
116 checks passed
@systay systay deleted the derived-unexpanded-table-dont-panic branch December 15, 2023 19:27
ejortegau referenced this pull request in slackhq/vitess Jan 24, 2024
@systay @ejortegau
bugfix: don't panic when missing schema information (#14787)
867ec31 
Signed-off-by: Eduardo J. Ortega U. <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@arthurschreiber arthurschreiber arthurschreiber approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Bug
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.

Unexpanded derived tables panic without schema tracking
3 participants
@systay @arthurschreiber @GuptaManan100