Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ejortegau/txthrottler dont throttle unless lag #14773

Closed
wants to merge 120 commits into from
Closed

Ejortegau/txthrottler dont throttle unless lag #14773

wants to merge 120 commits into from

Conversation

ejortegau
Copy link
Contributor

Description

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

maksimov and others added 30 commits November 6, 2023 21:34
@maksimov
add dependabot config (vitessio#153)
626907b 
* add dependabot config

* change dependabot to daily

* add 12.0.5 to dependabot
@timvaillancourt
Merge branch 'vitessio:main' into main
7690988
@deepthi @ejortegau
examples: fix flag syntax for zkctl (vitessio#14469)
e6ad43b 
Signed-off-by: deepthi <[email protected]>
@systay @ejortegau
Add support for AVG on sharded queries (vitessio#14419)
cb30f78
@dependabot @frouioui
@dbussink @ejortegau
Bump google.golang.org/grpc from 1.55.0-dev to 1.56.3 (vitessio#14364)
df8b428 
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Florent Poinsard <[email protected]>
Co-authored-by: Dirkjan Bussink <[email protected]>
@systay @ejortegau
Refactor: use NonEmpty() instead of !IsEmpty() (vitessio#14499)
9b1ce78
@harshit-gangal @GuptaManan100 @ejortegau
Foreign key on update action with non literal values (vitessio#14278)
f653ae1 
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Co-authored-by: Manan Gupta <[email protected]>
@systay @ejortegau
planbuilder bugfix: expose columns through derived tables (vitessio#1…
8c80b7f 
…4501)

Signed-off-by: Andres Taylor <[email protected]>
@github-actions @frouioui
@harshit-gangal @ejortegau
[main] Upgrade the Golang version to go1.21.4 (vitessio#14488)
eeac346 
Signed-off-by: GitHub <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Co-authored-by: frouioui <[email protected]>
Co-authored-by: Harshit Gangal <[email protected]>
@harshit-gangal @ejortegau
move over 16.0.6 and 17.0.4 release notes to main (vitessio#14508)
5379551 
Signed-off-by: Harshit Gangal <[email protected]>
@GuptaManan100 @ejortegau
Add SHOW VSCHEMA KEYSPACES query (vitessio#14505)
cb45185 
Signed-off-by: Manan Gupta <[email protected]>
@lixin963 @ejortegau
Update create_release.sh (vitessio#14492)
cb98acd
@deepthi @ejortegau
release notes: add FK import to summary (vitessio#14518)
22f1b22 
Signed-off-by: deepthi <[email protected]>
@shlomi-noach @ejortegau
Support fast_analyze_table variable, introduced in public MySQL fork (
71bd1e0 
vitessio#14494)

Signed-off-by: Shlomi Noach <[email protected]>
@shlomi-noach @ejortegau
Online DDL: edit CONSTRAINT names in CREATE TABLE (vitessio#14517)
4577732 
Signed-off-by: Shlomi Noach <[email protected]>
@shlomi-noach @ejortegau
Online DDL: fix endtoend test dropping foreign key (vitessio#14522)
43d72a8 
Signed-off-by: Shlomi Noach <[email protected]>
@shlomi-noach @ejortegau
MysqlCtl: implement missing ReadBinlogFilesTimestamps function (vit…
1cad333 
…essio#14525)

Signed-off-by: Shlomi Noach <[email protected]>
@harshit-gangal @GuptaManan100 @ejortegau
Replace into statement plan with foreign keys : unsharded (vitessio…
f2b9ef8 
…#14396)

Signed-off-by: Harshit Gangal <[email protected]>
Co-authored-by: Manan Gupta <[email protected]>
@dbussink @GuptaManan100 @ejortegau
Reduce wait time in test helpers (vitessio#14476)
22e4c20 
Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Co-authored-by: Manan Gupta <[email protected]>
@mattlord @ejortegau
VReplication: VTTablet flag cleanup (vitessio#14297)
fd04502 
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
Co-authored-by: Andrew Mason <[email protected]>
@aquarapid @deepthi @ejortegau
Fix vitessio#14414: resilient_server metrics name/prefix logic is inv…
29c1272 
…erted, leading to no metrics being recorded (vitessio#14415)

Signed-off-by: Jacques Grove <[email protected]>
Signed-off-by: deepthi <[email protected]>
Co-authored-by: deepthi <[email protected]>
@frouioui @ejortegau
Add HealthCheck's healthy map to the VTGate UI (vitessio#14521)
1881925
@frouioui @ejortegau
Fix missing query serving error code (vitessio#14520)
4edc0f3 
Signed-off-by: Florent Poinsard <[email protected]>
@GuptaManan100 @ejortegau
Fix type coercion in cascading non-literal updates (vitessio#14524)
e622992 
Signed-off-by: Manan Gupta <[email protected]>
@systay @ejortegau
Use hash joins when nested loop joins are not feasible (vitessio#14448)
ccf3017
@mattlord @ejortegau
Support cluster bootstrapping in vtctldclient (vitessio#14315)
b6ce0a0 
Signed-off-by: Matt Lord <[email protected]>
@arthurschreiber @patrickcarnahan
@harshit-gangal @ejortegau
Add support for new lock syntax in MySQL8 (vitessio#13965)
cf5f274 
Signed-off-by: Patrick Carnahan <[email protected]>
Signed-off-by: Arthur Schreiber <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Co-authored-by: Patrick Carnahan <[email protected]>
Co-authored-by: Harshit Gangal <[email protected]>
@mattrobenolt @ejortegau
Replace usages of bytes.Buffer with strings.Builder (vitessio#14539)
59d3d23 
Signed-off-by: Matt Robenolt <[email protected]>
@GuptaManan100 @ejortegau
Make Foreign_key_checks a Vitess Aware variable (vitessio#14484)
bda4f9a 
Signed-off-by: Manan Gupta <[email protected]>
@harshit-gangal @shlomi-noach @ejortegau
Enable Replace Into engine and Fix Foreign key locking issue (vites…
63aadd1 
…sio#14532)

Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Co-authored-by: Shlomi Noach <[email protected]>
GuptaManan100 and others added 24 commits December 13, 2023 10:19
@GuptaManan100 @ejortegau
Fix RegisterNotifier to use a copy of the tables to prevent data races (
26c557e 
vitessio#14716)

Signed-off-by: Manan Gupta <[email protected]>
@ejortegau
Reduce flakiness in TestShardReplicationPositions (vitessio#14708)
c02f941 
Signed-off-by: Andrew Mason <[email protected]>
@rohit-nayak-ps @ejortegau
Flaky TestFKExtWorkflow: fix Foreign Key stress test flakiness (vites…
093d723 
…sio#14714)
@iheanyi @ejortegau
Fix typo for --cells flag help description in ApplyRoutingRules (v…
9172bb3 
…itessio#14721)

Signed-off-by: Iheanyi Ekechukwu <[email protected]>
@frouioui @ejortegau
Add step to static check to ensure consistency of GHA workflows (vite…
f27a574 
…ssio#14724)
@vmg @ejortegau
connpool: fix racy test (vitessio#14731)
d3750cd 
Signed-off-by: Vicent Marti <[email protected]>
@dbussink @ejortegau
build: Allow compilation on Windows (vitessio#14718)
5c2f6b3 
Signed-off-by: Dirkjan Bussink <[email protected]>
@harshit-gangal @ejortegau
fix: flush tables with read lock to run only with reserved connection (…
6c68227 
…vitessio#14720)

Signed-off-by: Harshit Gangal <[email protected]>
@dbussink @ejortegau
mysql: Refactor out usage of servenv (vitessio#14732)
a2fe7ae 
Signed-off-by: Dirkjan Bussink <[email protected]>
@mattlord @ejortegau
TabletServer: Handle nil targets properly everywhere (vitessio#14734)
30ee133 
Signed-off-by: Matt Lord <[email protected]>
@mattlord @ejortegau
Replication: Have the DB flavor process waiting for a pos (vitessio#1…
76081ef 
…4745)

Signed-off-by: Matt Lord <[email protected]>
@tycol7 @ejortegau
Debug vars: Expose build version in /debug/vars (vitessio#14713)
ff40d03 
Signed-off-by: Tyler Coleman <[email protected]>
@rohit-nayak-ps @ejortegau
Keyspace ServedFrom: remove this deprecated attribute and related code (
a8550d8 
vitessio#14694)

Signed-off-by: Rohit Nayak <[email protected]>
@wlx5575 @ejortegau
fix: insert on duplicate key update missing BindVars (vitessio#14728)
8dc7600 
Co-authored-by: wlx5575 <[email protected]>
@frouioui @ejortegau
Add a retry to remove the vttablet directory during upgrade/downgrade…
a0239ea 
… backup tests (vitessio#14753)
@systay @GuptaManan100 @ejortegau
Optimise hash joins (vitessio#14644)
75e06df 
Co-authored-by: Manan Gupta <[email protected]>
@shlomi-noach @ejortegau
schemadiff: additional FK column type matching rules (vitessio#14751)
d75954f 
Signed-off-by: Shlomi Noach <[email protected]>
@dependabot @ejortegau
build(deps): bump com.google.guava:guava from 30.1.1-jre to 32.0.0-jr…
4d9ca44 
…e in /java (vitessio#14759)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@harshit-gangal @ejortegau
Add foreign key support for insert on duplicate key update (vitessio#…
31b0959 
…14638)

Signed-off-by: Harshit Gangal <[email protected]>
@deepthi @ejortegau
Use GetTabletsByCell in healthcheck (vitessio#14693)
a5cbcd1 
Signed-off-by: deepthi <[email protected]>
@harshit-gangal @frouioui @ejortegau
Pass on vindex errors with wrap than overriding them (vitessio#14737)
327549e 
Co-authored-by: Florent Poinsard <[email protected]>
@shlomi-noach @ejortegau
Tablet throttler: post 18 refactoring, race condition fixes, unit & r…
764d70c 
…ace testing, deprecation of HTTP checks (vitessio#14181)

Signed-off-by: Shlomi Noach <[email protected]>
@shlomi-noach @mattlord @ejortegau
Online DDL: support migration cut-over backoff and forced cut-over (v…
bebddba 
…itessio#14546)

Signed-off-by: Shlomi Noach <[email protected]>
Co-authored-by: Matt Lord <[email protected]>
@ejortegau
TxThrottler only throttles if current lag is above threshold.
39ad5e6 
Signed-off-by: Eduardo J. Ortega U <[email protected]>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 13, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 13, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Dec 13, 2023
@ejortegau ejortegau closed this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi Awaiting requested review from deepthi deepthi will be requested when the pull request is marked ready for review deepthi is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal will be requested when the pull request is marked ready for review harshit-gangal is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord will be requested when the pull request is marked ready for review mattlord is a code owner

@ajm188 ajm188 Awaiting requested review from ajm188 ajm188 will be requested when the pull request is marked ready for review ajm188 is a code owner

@notfelineit notfelineit Awaiting requested review from notfelineit notfelineit will be requested when the pull request is marked ready for review notfelineit is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui will be requested when the pull request is marked ready for review frouioui is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps will be requested when the pull request is marked ready for review rohit-nayak-ps is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 will be requested when the pull request is marked ready for review GuptaManan100 is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins will be requested when the pull request is marked ready for review derekperkins is a code owner

@systay systay Awaiting requested review from systay systay will be requested when the pull request is marked ready for review systay is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach will be requested when the pull request is marked ready for review shlomi-noach is a code owner

@timvaillancourt timvaillancourt Awaiting requested review from timvaillancourt timvaillancourt will be requested when the pull request is marked ready for review timvaillancourt is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber will be requested when the pull request is marked ready for review arthurschreiber is a code owner

@vmg vmg Awaiting requested review from vmg vmg will be requested when the pull request is marked ready for review vmg is a code owner

Assignees
No one assigned
Labels
NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.