Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass on vindex errors with wrap than overriding them #14737

Merged
merged 7 commits into from
Dec 12, 2023
Merged

Pass on vindex errors with wrap than overriding them #14737

merged 7 commits into from
Dec 12, 2023

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Dec 8, 2023 •
edited
Loading

Description

This PR passes the original error message with wrapped message. It fixes the error codes returned to the caller and also fixes the error metrics with correct error code.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 8, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 8, 2023
@vitess-bot vitess-bot bot mentioned this pull request Dec 8, 2023
Merged
@github-actions github-actions bot added this to the v19.0.0 milestone Dec 8, 2023
@harshit-gangal harshit-gangal removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Dec 11, 2023
@harshit-gangal
fix test setup
0c51f98 
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal
fix test error message
a77b0bf 
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal harshit-gangal marked this pull request as ready for review December 11, 2023 10:53
@harshit-gangal harshit-gangal removed the NeedsIssue A linked issue is missing for this Pull Request label Dec 11, 2023
systay

This comment was marked as resolved.

Sign in to view

systay
systay reviewed Dec 12, 2023
View reviewed changes
go/test/endtoend/vtgate/misc_test.go
conn, closer := start(t)
defer closer()

oldErrCount := getVtgateApiErrorCounts(t)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so nice :)

frouioui
frouioui reviewed Dec 12, 2023
View reviewed changes
go/vt/vterrors/code.go
Comment on lines +138 to +139
VT03028,
VT03029,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VT03030 is missing from this list

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed via b7f07d9

frouioui
frouioui approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although there is something to address in the code.go file

@frouioui
Copy link
Member

frouioui commented Dec 12, 2023 •
edited
Loading

https://github.com/vitessio/website/pull/1648/files is missing the VT03030 error code, adding Do Not Merge to not merge this PR by accident until resolved :)

@frouioui
add missing error code to the list
b7f07d9 
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui frouioui merged commit 5ee1b9b into vitessio:main Dec 12, 2023
116 of 117 checks passed
@frouioui frouioui deleted the lkp-errors-fix branch December 12, 2023 22:10
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Dec 13, 2023
@harshit-gangal @frouioui @ejortegau
Pass on vindex errors with wrap than overriding them (vitessio#14737)
327549e 
Co-authored-by: Florent Poinsard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@systay systay systay approved these changes

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Bug Type: Internal Cleanup
Projects
None yet
Milestone
v19.0.0
3 participants
@harshit-gangal @frouioui @systay