Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-18.0] increase vtctlclient backupShard command success rate (#14604) #14639

Merged
merged 1 commit into from
Nov 30, 2023
Merged

[release-18.0] increase vtctlclient backupShard command success rate (#14604) #14639

merged 1 commit into from
Nov 30, 2023

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Nov 30, 2023

Description

This is a backport of #14604

@vitess-bot @ajm188
increase vtctlclient backupShard command success rate (#14604)
a31687e 
Signed-off-by: Jun Wang <[email protected]>
Signed-off-by: jwangace <[email protected]>
Co-authored-by: Jun Wang <[email protected]>
Co-authored-by: Andrew Mason <[email protected]>
@vitess-bot vitess-bot bot requested a review from notfelineit as a code owner November 30, 2023 07:03
@vitess-bot vitess-bot bot added the Type: Enhancement Logical improvement (somewhere between a bug and feature) label Nov 30, 2023
@vitess-bot vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Nov 30, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@shlomi-noach
Copy link
Contributor

@ajm188 I created this backport just in case, what is your opinion on backporting to release-18.0?

@github-actions github-actions bot added this to the v18.0.2 milestone Nov 30, 2023
@ajm188
Copy link
Contributor

ajm188 commented Nov 30, 2023

@ajm188 I created this backport just in case, what is your opinion on backporting to release-18.0?

i don't see a reason not to; could be nice improvement if/when we do a patch release. should we backport to other supported versions as well?

@shlomi-noach
Copy link
Contributor

should we backport to other supported versions as well?

We'd have to do that manually since the original PR is already merged.

@shlomi-noach shlomi-noach merged commit f004f79 into release-18.0 Nov 30, 2023
230 of 231 checks passed
@shlomi-noach shlomi-noach deleted the backport-14604-to-release-18.0 branch November 30, 2023 13:22
@ajm188
Copy link
Contributor

ajm188 commented Nov 30, 2023

We'd have to do that manually since the original PR is already merged.

alright let's see if it gets asked for, in that case 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@ajm188 ajm188 Awaiting requested review from ajm188 ajm188 is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@notfelineit notfelineit Awaiting requested review from notfelineit notfelineit is a code owner

Assignees
No one assigned
Labels
Backport This is a backport Component: Backup and Restore Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
v18.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@shlomi-noach @ajm188