Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wait for reading mycnf to prevent race #14626

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

GuptaManan100
Copy link
Member

Description

This PR fixes the other issue pointed out in #14562 namely, there's an issue with mysqlctld creating my.cnf and vttablet racing to read it if both are started in parallel. That can result in the following error:

Error: mycnf read failed: open /vt/vtdataroot/vt_1320004125/my.cnf: no such file or directory

This wasn't a huge issue because it failed vttablets and when restarted, it would eventually work fine. But we can improve this experience by inherently having a wait time to read the cnf file if it isn't immediately available.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@GuptaManan100 GuptaManan100 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Cluster management labels Nov 28, 2023
Copy link
Contributor

vitess-bot bot commented Nov 28, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 28, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Nov 28, 2023
@GuptaManan100 GuptaManan100 removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request labels Nov 28, 2023
go/flags/endtoend/vtbackup.txt Outdated Show resolved Hide resolved
go/vt/mysqlctl/mycnf.go Outdated Show resolved Hide resolved
Copy link
Contributor

@dbussink dbussink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is already in the right spot so it only runs on managed MySQL instances.

@deepthi deepthi merged commit 9850f01 into vitessio:main Nov 29, 2023
117 checks passed
@deepthi deepthi deleted the vttablet-mycnf-wait branch November 29, 2023 23:47
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Cluster management Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: mysqlctld and vttablet startup is racy for a new instance
4 participants